From 2dabb5415349be6a04b18f33544fc8e0768b31fe Mon Sep 17 00:00:00 2001 From: "Mingyu Chen (Rayner)" Date: Thu, 13 Feb 2025 15:43:28 +0800 Subject: [PATCH] [opt](trino-connector) close scanner after finished (#47857) ### What problem does this PR solve? The source should be closed after scanner is done to save memory. Or there will be some objects remaining like: ``` 13: 192980 9263040 org.apache.kudu.client.RowwiseRowResult ``` Although these objects can be gc, eventually. --- .../apache/doris/trinoconnector/TrinoConnectorJniScanner.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorJniScanner.java b/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorJniScanner.java index 6b15abfa413043..2138a432037e8a 100644 --- a/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorJniScanner.java +++ b/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorJniScanner.java @@ -179,6 +179,9 @@ public void open() throws IOException { @Override public void close() throws IOException { + if (source != null) { + source.close(); + } } @Override