Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-20](bug) fix analytic illegal frame range #47653

Open
wants to merge 1 commit into
base: branch-2.0
Choose a base branch
from

Conversation

zhangstar333
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #(#41147)

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49360 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d44f7a561c1ba3d62eee3096448191e42f169f8, data reload: false

------ Round 1 ----------------------------------
q1	17903	4521	4417	4417
q2	2137	163	146	146
q3	10462	1927	1885	1885
q4	10370	1289	1313	1289
q5	8508	3938	3979	3938
q6	233	125	127	125
q7	2052	1607	1603	1603
q8	9493	2708	2711	2708
q9	13925	10025	9902	9902
q10	8616	3546	3470	3470
q11	412	255	256	255
q12	474	293	295	293
q13	18359	3948	4046	3948
q14	359	329	332	329
q15	508	471	463	463
q16	530	460	454	454
q17	1137	977	987	977
q18	7273	6792	6837	6792
q19	1712	1617	1565	1565
q20	535	326	301	301
q21	4453	4098	4099	4098
q22	488	402	405	402
Total cold run time: 119939 ms
Total hot run time: 49360 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4332	4319	4330	4319
q2	320	230	228	228
q3	4197	4166	4155	4155
q4	2770	2757	2746	2746
q5	7234	7190	7229	7190
q6	237	127	122	122
q7	3235	2850	2817	2817
q8	4369	4430	4488	4430
q9	14275	13815	14059	13815
q10	4235	4259	4280	4259
q11	744	687	695	687
q12	1032	885	865	865
q13	6906	3735	3729	3729
q14	454	426	436	426
q15	494	461	459	459
q16	634	595	599	595
q17	3805	3861	3789	3789
q18	8852	8759	8652	8652
q19	1727	1654	1656	1654
q20	2418	2162	2147	2147
q21	8578	8456	8560	8456
q22	1045	963	893	893
Total cold run time: 81893 ms
Total hot run time: 76433 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 213615 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4d44f7a561c1ba3d62eee3096448191e42f169f8, data reload: false

query1	945	426	379	379
query2	6557	2167	2234	2167
query3	6928	204	207	204
query4	23858	21468	21446	21446
query5	19739	6454	6572	6454
query6	289	219	243	219
query7	4355	302	320	302
query8	286	240	244	240
query9	3118	2686	2616	2616
query10	466	318	306	306
query11	15643	15237	15274	15237
query12	128	81	73	73
query13	1036	473	451	451
query14	17445	13786	13609	13609
query15	399	221	231	221
query16	6502	278	261	261
query17	1736	927	940	927
query18	906	317	320	317
query19	218	162	152	152
query20	99	97	102	97
query21	188	97	97	97
query22	5220	4964	5000	4964
query23	34407	33587	33615	33587
query24	7862	6348	6368	6348
query25	538	430	428	428
query26	1264	170	172	170
query27	2429	300	294	294
query28	6078	2303	2276	2276
query29	2846	2647	2760	2647
query30	248	169	167	167
query31	1002	740	751	740
query32	68	62	62	62
query33	461	272	269	269
query34	864	480	503	480
query35	1156	938	957	938
query36	1408	1161	1175	1161
query37	177	64	63	63
query38	3098	3000	2906	2906
query39	1388	1334	1330	1330
query40	309	94	101	94
query41	42	40	38	38
query42	87	91	88	88
query43	627	724	591	591
query44	1164	723	722	722
query45	244	234	233	233
query46	1264	965	981	965
query47	1823	1741	1700	1700
query48	514	410	417	410
query49	665	369	389	369
query50	852	611	627	611
query51	4819	4715	4695	4695
query52	90	84	91	84
query53	234	190	200	190
query54	2662	2500	2480	2480
query55	91	92	85	85
query56	229	207	216	207
query57	1314	1179	1158	1158
query58	223	206	218	206
query59	3364	3454	3289	3289
query60	221	216	209	209
query61	103	102	100	100
query62	825	439	494	439
query63	207	177	181	177
query64	3556	1598	1506	1506
query65	3636	3566	3549	3549
query66	781	434	445	434
query67	17849	15156	17372	15156
query68	8861	630	650	630
query69	506	273	279	273
query70	1633	1252	1567	1252
query71	393	297	308	297
query72	6908	4837	4887	4837
query73	776	321	321	321
query74	6341	5790	5871	5790
query75	4532	3761	3702	3702
query76	4548	1155	1212	1155
query77	534	251	257	251
query78	13250	12440	11892	11892
query79	7388	633	643	633
query80	2026	391	409	391
query81	530	235	236	235
query82	1320	101	96	96
query83	184	134	131	131
query84	261	73	71	71
query85	811	324	334	324
query86	368	301	295	295
query87	3233	3008	3044	3008
query88	4718	2299	2309	2299
query89	384	289	288	288
query90	1749	222	226	222
query91	162	127	129	127
query92	65	53	52	52
query93	5161	575	590	575
query94	838	213	209	209
query95	2028	2056	2022	2022
query96	647	318	325	318
query97	6538	6489	6507	6489
query98	224	200	214	200
query99	2815	849	840	840
Total cold run time: 318882 ms
Total hot run time: 213615 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.01 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d44f7a561c1ba3d62eee3096448191e42f169f8, data reload: false

query1	0.03	0.02	0.03
query2	0.08	0.03	0.03
query3	0.25	0.04	0.04
query4	1.77	0.06	0.07
query5	0.56	0.52	0.52
query6	1.27	0.62	0.62
query7	0.01	0.01	0.01
query8	0.04	0.02	0.03
query9	0.52	0.49	0.49
query10	0.52	0.54	0.54
query11	0.13	0.09	0.08
query12	0.12	0.09	0.10
query13	0.61	0.62	0.61
query14	0.79	0.77	0.80
query15	0.79	0.76	0.77
query16	0.36	0.35	0.37
query17	1.02	1.01	0.96
query18	0.22	0.26	0.25
query19	1.86	1.85	1.85
query20	0.02	0.01	0.01
query21	15.46	0.56	0.55
query22	2.31	2.78	2.72
query23	17.35	1.07	0.79
query24	5.54	2.85	1.27
query25	0.36	0.13	0.06
query26	0.71	0.16	0.16
query27	0.04	0.03	0.04
query28	5.66	0.77	0.78
query29	12.65	2.23	2.22
query30	0.55	0.54	0.50
query31	2.82	0.39	0.38
query32	3.36	0.49	0.50
query33	3.09	3.06	3.05
query34	15.24	4.83	4.83
query35	4.88	4.87	4.86
query36	1.08	1.01	1.00
query37	0.06	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.15
query41	0.07	0.02	0.01
query42	0.03	0.01	0.02
query43	0.02	0.01	0.02
Total cold run time: 102.47 s
Total hot run time: 32.01 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 4d44f7a561c1ba3d62eee3096448191e42f169f8 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.0 seconds inserted 10000000 Rows, about 476K ops/s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.57% (8313/21555)
Line Coverage: 30.26% (68763/227217)
Region Coverage: 29.69% (35412/119276)
Branch Coverage: 25.44% (18199/71528)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4d44f7a561c1ba3d62eee3096448191e42f169f8_4d44f7a561c1ba3d62eee3096448191e42f169f8/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants