Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor](fe) remove some forward session var logic #47649

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Feb 8, 2025

What problem does this PR solve?

Should all depdend on session var's forward logic to do option forward logic. Some session var is not set FORWARD=true, I set it.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

yiguolei commented Feb 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31685 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f44dfe3c59bca4a971b2b22e0ea04c7cacfbd2b7, data reload: false

------ Round 1 ----------------------------------
q1	17648	5153	5079	5079
q2	2046	307	176	176
q3	10449	1330	747	747
q4	10280	1036	548	548
q5	8229	2432	2320	2320
q6	190	168	138	138
q7	917	737	625	625
q8	9308	1296	1090	1090
q9	5559	4738	4750	4738
q10	6817	2307	1880	1880
q11	492	267	253	253
q12	342	348	212	212
q13	17775	3654	3111	3111
q14	221	220	215	215
q15	523	466	467	466
q16	641	608	596	596
q17	546	875	331	331
q18	6972	6244	6188	6188
q19	1263	975	537	537
q20	310	324	194	194
q21	2872	2176	1940	1940
q22	360	330	301	301
Total cold run time: 103760 ms
Total hot run time: 31685 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5112	5168	5086	5086
q2	238	330	227	227
q3	2171	2709	2271	2271
q4	1517	1879	1429	1429
q5	4248	4130	4156	4130
q6	201	163	124	124
q7	1837	1852	1794	1794
q8	2638	2555	2571	2555
q9	7139	7096	7059	7059
q10	3017	3218	2731	2731
q11	581	507	490	490
q12	686	749	617	617
q13	3631	3895	3224	3224
q14	285	306	272	272
q15	527	474	460	460
q16	645	677	647	647
q17	1110	1499	1406	1406
q18	7628	7280	7102	7102
q19	803	816	936	816
q20	1951	1986	1862	1862
q21	5469	4923	4884	4884
q22	643	578	543	543
Total cold run time: 52077 ms
Total hot run time: 49729 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183102 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f44dfe3c59bca4a971b2b22e0ea04c7cacfbd2b7, data reload: false

query1	973	444	364	364
query2	6527	1932	1903	1903
query3	6821	213	213	213
query4	27117	23597	23083	23083
query5	4320	643	492	492
query6	315	204	192	192
query7	4613	504	303	303
query8	301	249	238	238
query9	8623	2573	2564	2564
query10	464	310	249	249
query11	15807	15221	15107	15107
query12	156	105	105	105
query13	1671	517	386	386
query14	9754	6588	6190	6190
query15	208	189	174	174
query16	7211	628	463	463
query17	1175	696	571	571
query18	1943	384	296	296
query19	192	192	152	152
query20	120	121	114	114
query21	206	121	100	100
query22	3979	4414	4292	4292
query23	33797	32850	32919	32850
query24	7695	2344	2364	2344
query25	530	442	389	389
query26	1236	265	147	147
query27	2227	481	333	333
query28	4024	2390	2387	2387
query29	715	546	424	424
query30	231	182	158	158
query31	934	892	790	790
query32	69	65	65	65
query33	560	378	321	321
query34	808	845	498	498
query35	795	812	713	713
query36	985	989	907	907
query37	123	98	79	79
query38	4130	4228	4074	4074
query39	1470	1371	1398	1371
query40	205	116	102	102
query41	54	51	51	51
query42	123	107	104	104
query43	510	518	487	487
query44	1273	781	780	780
query45	179	166	159	159
query46	836	1058	635	635
query47	1740	1783	1707	1707
query48	375	404	312	312
query49	792	511	414	414
query50	682	718	400	400
query51	4145	4181	4030	4030
query52	110	109	97	97
query53	219	252	187	187
query54	502	488	407	407
query55	86	79	79	79
query56	265	294	256	256
query57	1139	1152	1077	1077
query58	259	242	250	242
query59	2668	2711	2579	2579
query60	286	276	291	276
query61	151	139	143	139
query62	795	713	656	656
query63	224	190	193	190
query64	4325	1038	645	645
query65	3225	3188	3128	3128
query66	1129	421	333	333
query67	15723	15756	15392	15392
query68	5246	766	519	519
query69	467	288	261	261
query70	1206	1188	1097	1097
query71	401	292	251	251
query72	6092	3579	3750	3579
query73	742	739	353	353
query74	9101	9161	8699	8699
query75	3174	3191	2704	2704
query76	3215	1184	737	737
query77	474	353	278	278
query78	10029	10312	9298	9298
query79	1831	773	577	577
query80	669	535	467	467
query81	519	277	251	251
query82	220	158	120	120
query83	175	171	158	158
query84	242	89	76	76
query85	791	438	304	304
query86	359	295	292	292
query87	4344	4610	4369	4369
query88	2841	2188	2186	2186
query89	385	318	285	285
query90	1786	192	196	192
query91	140	142	109	109
query92	68	65	58	58
query93	1117	981	576	576
query94	618	397	306	306
query95	368	262	256	256
query96	480	546	264	264
query97	2761	2827	2733	2733
query98	237	211	207	207
query99	1324	1397	1275	1275
Total cold run time: 266267 ms
Total hot run time: 183102 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f44dfe3c59bca4a971b2b22e0ea04c7cacfbd2b7, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.10	0.10
query5	0.42	0.41	0.41
query6	1.14	0.67	0.64
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.51	0.53
query10	0.57	0.57	0.56
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.62	0.59	0.61
query14	2.76	2.68	2.84
query15	0.94	0.86	0.85
query16	0.38	0.38	0.37
query17	1.00	1.03	1.05
query18	0.21	0.20	0.20
query19	1.93	1.84	2.03
query20	0.01	0.01	0.01
query21	15.35	0.92	0.55
query22	0.75	1.28	0.69
query23	14.81	1.37	0.66
query24	7.30	1.92	0.57
query25	0.48	0.22	0.11
query26	0.66	0.16	0.12
query27	0.05	0.05	0.05
query28	9.12	0.84	0.42
query29	12.54	3.95	3.27
query30	0.25	0.10	0.06
query31	2.81	0.58	0.37
query32	3.23	0.55	0.46
query33	3.03	2.99	3.01
query34	15.83	5.14	4.54
query35	4.56	4.57	4.55
query36	0.65	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.14
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.78 s
Total hot run time: 30.39 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Feb 9, 2025

PR approved by anyone and no changes requested.

@suxiaogang223
Copy link
Contributor

+1

@yiguolei yiguolei merged commit 89c3e91 into apache:master Feb 9, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants