-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](local exchange) Simplify block wrapper #47620
Conversation
run buildall |
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 23414 ms
|
run buildall |
TPC-H: Total hot run time: 31540 ms
|
TPC-DS: Total hot run time: 182942 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClickBench: Total hot run time: 30.31 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TeamCity be ut coverage result: |
What problem does this PR solve?
Block wrapper which is used by local exchanger maintains a data block and a reference count which indicates if the block could be freed.
This PR simplify the control logics. A block wrapper will be hold by a shared pointer and we just clear the data block in the de-constructor instead of relying another ref count.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)