Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse: Support underscore in numbers #1659

Closed
hansott opened this issue Jan 16, 2025 · 0 comments · Fixed by #1677
Closed

Clickhouse: Support underscore in numbers #1659

hansott opened this issue Jan 16, 2025 · 0 comments · Fixed by #1677

Comments

@hansott
Copy link
Contributor

hansott commented Jan 16, 2025

See https://clickhouse.com/docs/en/sql-reference/syntax#numeric

SELECT 10_000_000
[
    Word(
        Word {
            value: "SELECT",
            quote_style: None,
            keyword: SELECT,
        },
    ),
    Whitespace(
        Space,
    ),
    Number(
        "10",
        false,
    ),
    Word(
        Word {
            value: "_000_000",
            quote_style: None,
            keyword: NoKeyword,
        },
    ),
]
@hansott hansott changed the title Clickhouse dialect: Support underscore in numbers Clickhouse: Support underscore in numbers Jan 16, 2025
graup added a commit to graup/datafusion-sqlparser-rs that referenced this issue Jan 22, 2025
@iffyio iffyio closed this as completed in 269967a Jan 28, 2025
Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this issue Feb 3, 2025
Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this issue Feb 3, 2025
Vedin added a commit to Embucket/datafusion-sqlparser-rs that referenced this issue Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant