From 2a3bb66d777e2b7f195a0f3d9757384e12742990 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 7 Dec 2024 07:40:20 -0500 Subject: [PATCH 1/3] Improve MSRV failure CI JOB output display --- .github/workflows/rust.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index ff5040fd2947..5f0b236702ed 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -126,13 +126,13 @@ jobs: run: cargo update -p ahash --precise 0.8.7 - name: Check arrow working-directory: arrow - run: cargo msrv --log-target stdout verify + run: cargo msrv verify - name: Check parquet working-directory: parquet - run: cargo msrv --log-target stdout verify + run: cargo msrv verify - name: Check arrow-flight working-directory: arrow-flight - run: cargo msrv --log-target stdout verify + run: cargo msrv verify - name: Downgrade object_store dependencies working-directory: object_store # Necessary because tokio 1.30.0 updates MSRV to 1.63 @@ -142,4 +142,4 @@ jobs: cargo update -p url --precise 2.5.0 - name: Check object_store working-directory: object_store - run: cargo msrv --log-target stdout verify + run: cargo msrv verify From 54a080135e79fc8ae33fa5b6b9d054f0d3fe3ff0 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 7 Dec 2024 07:41:26 -0500 Subject: [PATCH 2/3] purposely introduce msrv brek --- arrow-schema/Cargo.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/arrow-schema/Cargo.toml b/arrow-schema/Cargo.toml index 628d4a683cac..230373f11c98 100644 --- a/arrow-schema/Cargo.toml +++ b/arrow-schema/Cargo.toml @@ -36,6 +36,7 @@ bench = false [dependencies] serde = { version = "1.0", default-features = false, features = ["derive", "std", "rc"], optional = true } bitflags = { version = "2.0.0", default-features = false, optional = true } +criterion = { version = "0.5", default-features = false } [features] # Enable ffi support From ff90721060ffe3f2712f1e27c717a86a57fd23a0 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 7 Dec 2024 14:56:04 -0500 Subject: [PATCH 3/3] Change output format display to json --- .github/workflows/rust.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 5f0b236702ed..f455bb341461 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -126,13 +126,13 @@ jobs: run: cargo update -p ahash --precise 0.8.7 - name: Check arrow working-directory: arrow - run: cargo msrv verify + run: cargo msrv verify --output-format json - name: Check parquet working-directory: parquet - run: cargo msrv verify + run: cargo msrv verify --output-format json - name: Check arrow-flight working-directory: arrow-flight - run: cargo msrv verify + run: cargo msrv verify --output-format json - name: Downgrade object_store dependencies working-directory: object_store # Necessary because tokio 1.30.0 updates MSRV to 1.63 @@ -142,4 +142,4 @@ jobs: cargo update -p url --precise 2.5.0 - name: Check object_store working-directory: object_store - run: cargo msrv verify + run: cargo msrv verify --output-format json