Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark CI: Debian #85

Open
kou opened this issue Sep 5, 2024 · 7 comments · May be fixed by #250
Open

Add benchmark CI: Debian #85

kou opened this issue Sep 5, 2024 · 7 comments · May be fixed by #250

Comments

@kou
Copy link
Member

kou commented Sep 5, 2024

This part: https://github.com/apache/arrow/blob/8113594c85b4c578236cdd69d4155e0e118744b4/.github/workflows/go.yml#L136-L163

@singh1203
Copy link

Hello @kou, I would love to work on this issue. Looking at the description, I understand it involves implementing a benchmarking CI workflow for the arrow-go repository using Debian as the runtime environment.
Correct me if I am wrong.
Thank you.

@kou
Copy link
Member Author

kou commented Jan 8, 2025

Correct.

But we need help from others:

  • We need to set secrets for CONBENCH_EMAIL and CONBENCH_PASSWORD to apache/arrow-go
  • We need to confirm that apache/arrow-go can use https://conbench.ursa.dev/ like apache/arrow

@assignUser Could you help us?

@kou
Copy link
Member Author

kou commented Jan 10, 2025

See also: apache/arrow#44996

@assignUser
Copy link
Member

I think we should keep running the go builds on github runners, the setup and maintenance is just much less complicated. As in the monorepo we can still upload the results to conbench. When the PR for this is ready I can handle creating the secrets and open an infra ticket to get them set in the repo.

@raulcd
Copy link
Member

raulcd commented Jan 10, 2025

I think we should keep running the go builds on github runners

Do you mean start using GitHub runners instead of the dedicated buildkite infra to run this new benchmarks?
Even though this will probably make the benchmark reports slightly more unstable I do agree that given the current status it would be better. If we ever want to have dedicated runners we can discuss this with Infra maybe?

@assignUser
Copy link
Member

Yes. Go has never used the buildkite infra and I think it should work for the rest as well and make everything more transparent to the community.

@singh1203
Copy link

Yes. Go has never used the buildkite infra and I think it should work for the rest as well and make everything more transparent to the community.

Okay, I think it's a green signal for me to start working on it and to be more specific I should add the Benchmark job in the test runner file to leverage :

  • Reuse of Configuration
  • Centralized Management
  • Fewer files to manage

However, in my opinion, it increases complexity because benchmarks differ from test purposes.

@singh1203 singh1203 linked a pull request Jan 15, 2025 that will close this issue
singh1203 added a commit to singh1203/arrow-go that referenced this issue Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants