Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Taskflow API in Task SDK & template rendering #45232

Closed
Tracked by #44481
kaxil opened this issue Dec 27, 2024 · 0 comments · Fixed by #45444
Closed
Tracked by #44481

Add support for Taskflow API in Task SDK & template rendering #45232

kaxil opened this issue Dec 27, 2024 · 0 comments · Fixed by #45444
Assignees
Labels
area:API Airflow's REST/HTTP API

Comments

@kaxil
Copy link
Member

kaxil commented Dec 27, 2024

No description provided.

@kaxil kaxil self-assigned this Dec 27, 2024
@dosubot dosubot bot added the area:API Airflow's REST/HTTP API label Dec 27, 2024
@kaxil kaxil moved this from Next 2 Weeks to In Progress in AIP-72 - Task Execution Interface and SDK Jan 6, 2025
kaxil added a commit to astronomer/airflow that referenced this issue Jan 6, 2025
kaxil added a commit to astronomer/airflow that referenced this issue Jan 6, 2025
kaxil added a commit to astronomer/airflow that referenced this issue Jan 6, 2025
closes apache#45232

The Templater class has been moved to the Task SDK to align with the language-specific aspects of template rendering. Templating logic is inherently tied to Python constructs. By keeping the Templater class within the Task SDK, we ensure that the core templating logic remains coupled with language-specific implementations.

Options I had were keeping it on the Schdeuler or the Execution side of Task SDK, neither of which is ideal as we would want to change the code in definition like DAG, Operator alongwith how it renders.
kaxil added a commit to astronomer/airflow that referenced this issue Jan 6, 2025
closes apache#45232

The Templater class has been moved to the Task SDK to align with the language-specific aspects of template rendering. Templating logic is inherently tied to Python constructs. By keeping the Templater class within the Task SDK, we ensure that the core templating logic remains coupled with language-specific implementations.

Options I had were keeping it on the Schdeuler or the Execution side of Task SDK, neither of which is ideal as we would want to change the code in definition like DAG, Operator alongwith how it renders.
kaxil added a commit to astronomer/airflow that referenced this issue Jan 7, 2025
closes apache#45232

The Templater class has been moved to the Task SDK to align with the language-specific aspects of template rendering. Templating logic is inherently tied to Python constructs. By keeping the Templater class within the Task SDK, we ensure that the core templating logic remains coupled with language-specific implementations.

Options I had were keeping it on the Schdeuler or the Execution side of Task SDK, neither of which is ideal as we would want to change the code in definition like DAG, Operator alongwith how it renders.
@kaxil kaxil closed this as completed in b2a244b Jan 7, 2025
agupta01 pushed a commit to agupta01/airflow that referenced this issue Jan 13, 2025
…ache#45444)

closes apache#45232
part of apache#44481

The Templater class has been moved to the Task SDK to align with the language-specific aspects of template rendering. Templating logic is inherently tied to Python constructs. By keeping the Templater class within the Task SDK, we ensure that the core templating logic remains coupled with language-specific implementations.

Options I had were keeping it on the Schdeuler or the Execution side of Task SDK, neither of which is ideal as we would want to change the code in definition like DAG, Operator alongwith how it renders.

With [`tutorial_taskflow_api`](https://github.com/apache/airflow/blob/5581e65fd5575364fbf2c0e5c8cf4f4afe2b841b/airflow/example_dags/tutorial_taskflow_api.py#L38):

<img width="1705" alt="image" src="https://github.com/user-attachments/assets/c84327ed-5956-4f48-ab32-97a77ae44016" />

---
With [`example_xcom_args`](https://github.com/apache/airflow/blob/5581e65fd5575364fbf2c0e5c8cf4f4afe2b841b/airflow/example_dags/example_xcomargs.py):

<img width="1720" alt="image" src="https://github.com/user-attachments/assets/f9e0190f-1030-437d-ab6b-8247a5f8cdb0" />
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this issue Jan 16, 2025
…ache#45444)

closes apache#45232
part of apache#44481

The Templater class has been moved to the Task SDK to align with the language-specific aspects of template rendering. Templating logic is inherently tied to Python constructs. By keeping the Templater class within the Task SDK, we ensure that the core templating logic remains coupled with language-specific implementations.

Options I had were keeping it on the Schdeuler or the Execution side of Task SDK, neither of which is ideal as we would want to change the code in definition like DAG, Operator alongwith how it renders.

With [`tutorial_taskflow_api`](https://github.com/apache/airflow/blob/5581e65fd5575364fbf2c0e5c8cf4f4afe2b841b/airflow/example_dags/tutorial_taskflow_api.py#L38):

<img width="1705" alt="image" src="https://github.com/user-attachments/assets/c84327ed-5956-4f48-ab32-97a77ae44016" />

---
With [`example_xcom_args`](https://github.com/apache/airflow/blob/5581e65fd5575364fbf2c0e5c8cf4f4afe2b841b/airflow/example_dags/example_xcomargs.py):

<img width="1720" alt="image" src="https://github.com/user-attachments/assets/f9e0190f-1030-437d-ab6b-8247a5f8cdb0" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API
Development

Successfully merging a pull request may close this issue.

1 participant