From cbaea3f67b406d1baef979a176ed65532920f79f Mon Sep 17 00:00:00 2001 From: Tim Meier Date: Wed, 8 Jan 2025 12:08:21 +0100 Subject: [PATCH] Disable service binding per wizard by default --- .../add-service-instance.component.spec.ts | 7 +++++++ .../components/add-service-instance/csi-mode.service.ts | 5 ++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/add-service-instance/add-service-instance.component.spec.ts b/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/add-service-instance/add-service-instance.component.spec.ts index 2c3d53fa61..138350900e 100644 --- a/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/add-service-instance/add-service-instance.component.spec.ts +++ b/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/add-service-instance/add-service-instance.component.spec.ts @@ -153,4 +153,11 @@ describe('AddServiceInstanceComponent', () => { it('should create', () => { expect(component).toBeTruthy(); }); + + it("should not render bind services in the wizard by default", () => { + expect( + fixture.debugElement.query(By.css(".steppers__headers")).nativeElement + .textContent + ).not.toContain("Bind App"); + }); }); diff --git a/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/csi-mode.service.ts b/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/csi-mode.service.ts index 588d129690..983c341c1f 100644 --- a/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/csi-mode.service.ts +++ b/src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/csi-mode.service.ts @@ -50,7 +50,10 @@ const defaultViewDetail = { showSelectCf: true, showSelectService: true, showSelectServicePlan: true, - showBindApp: true, + // disable binding by default -> if services are created asyncronously it breaks the user experience + // its assumed being asynchronously by default: + // https://github.com/cloudfoundry-community/stratos/blob/develop/src/frontend/packages/cloud-foundry/src/actions/service-instances.actions.ts#L150 + showBindApp: false, showSpecifyDetails: true };