From 155720c94142a39c693b5fedb28dddceef84d5bd Mon Sep 17 00:00:00 2001 From: Jeff Moody <110494049+ansjmoody@users.noreply.github.com> Date: Fri, 17 Jan 2025 15:39:12 -0600 Subject: [PATCH 1/3] fix: changed Launcher.launch_sherlock() to properly append sherlock_command_args --- src/ansys/sherlock/core/launcher.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ansys/sherlock/core/launcher.py b/src/ansys/sherlock/core/launcher.py index b8cde32e..acc2a20a 100644 --- a/src/ansys/sherlock/core/launcher.py +++ b/src/ansys/sherlock/core/launcher.py @@ -82,7 +82,7 @@ def launch_sherlock( try: _is_port_available(host, port) except Exception as e: - print(str(e)) + LOG.error(str(e)) raise e _server_version = None @@ -95,8 +95,8 @@ def launch_sherlock( args.append("-singleProject") args.append(single_project_path) if sherlock_command_args != "": - args.append(f"{shlex.split(sherlock_command_args)}") - print(args) + args.extend(shlex.split(sherlock_command_args)) + LOG.info(f"Command arguments: {args}") subprocess.Popen(args) sherlock = connect_grpc_channel(port, _server_version) From c07d0680121eedc7c65578633d348deb87470ce9 Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Fri, 17 Jan 2025 21:47:52 +0000 Subject: [PATCH 2/3] chore: adding changelog file 487.miscellaneous.md [dependabot-skip] --- doc/changelog.d/487.miscellaneous.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/487.miscellaneous.md diff --git a/doc/changelog.d/487.miscellaneous.md b/doc/changelog.d/487.miscellaneous.md new file mode 100644 index 00000000..02a10771 --- /dev/null +++ b/doc/changelog.d/487.miscellaneous.md @@ -0,0 +1 @@ +fix: changed Launcher.launch_sherlock() to properly append sherlock_command_args \ No newline at end of file From 7f501d97d4e0a0bc4680fe498e3be74b906542e1 Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Fri, 17 Jan 2025 21:48:54 +0000 Subject: [PATCH 3/3] chore: adding changelog file 487.documentation.md [dependabot-skip] --- doc/changelog.d/{487.miscellaneous.md => 487.documentation.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename doc/changelog.d/{487.miscellaneous.md => 487.documentation.md} (100%) diff --git a/doc/changelog.d/487.miscellaneous.md b/doc/changelog.d/487.documentation.md similarity index 100% rename from doc/changelog.d/487.miscellaneous.md rename to doc/changelog.d/487.documentation.md