Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new API update_PTH_fatigue_props() #492

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: new API update_PTH_fatigue_props() #492

wants to merge 5 commits into from
+279 −2

Conversation

ansnfernand
Copy link
Collaborator

@ansnfernand ansnfernand commented Jan 28, 2025 •
edited
Loading

Description

new API update_PTH_fatigue_props()

Issue linked

#491

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added the enhancement New features or code improvements label Jan 28, 2025
@ansnfernand ansnfernand added this to the v0.9.0 milestone Jan 28, 2025
@ansnfernand ansnfernand self-assigned this Jan 28, 2025
@ansnfernand ansnfernand linked an issue Jan 28, 2025 that may be closed by this pull request
New API: update_PTH_analysis_props() #491
Open
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation dependencies Related with project dependencies maintenance Package and maintenance related labels Jan 28, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.29114% with 29 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (8f3ab1c) to head (bb64843).

Files with missing lines Patch % Lines
src/ansys/sherlock/core/types/analysis_types.py 66.66% 24 Missing ⚠️
src/ansys/sherlock/core/analysis.py 28.57% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   60.03%   60.07%   +0.04%     
==========================================
  Files          21       21              
  Lines        5062     5140      +78     
==========================================
+ Hits         3039     3088      +49     
- Misses       2023     2052      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand requested review from ansjmoody and anskhanson and removed request for ansjmoody February 4, 2025 13:40
@ansnfernand ansnfernand force-pushed the nayane/updatePTHFatigueProps branch from 76d74a2 to 98c5033 Compare February 6, 2025 14:36
@github-actions github-actions bot removed dependencies Related with project dependencies maintenance Package and maintenance related labels Feb 6, 2025
@ansnfernand ansnfernand force-pushed the nayane/updatePTHFatigueProps branch from 98c5033 to 43d61c0 Compare February 11, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anskhanson anskhanson anskhanson requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ansnfernand ansnfernand

Labels
documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

New API: update_PTH_analysis_props()
3 participants
@ansnfernand @anskhanson @pyansys-ci-bot