Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve on offline signing #4235

Open
grarco opened this issue Jan 14, 2025 · 0 comments
Open

Improve on offline signing #4235

grarco opened this issue Jan 14, 2025 · 0 comments

Comments

@grarco
Copy link
Collaborator

grarco commented Jan 14, 2025

There are a couple shortcomings in the current implementation of offline signing:

  1. Producing a signature with the hardware wallet is not supported
  2. Producing a MASP signature is not supported

To address the first point we should modify the SignOffline struct to accept a vector of PublicKeys instead of SecretKeys so that we could use those to call the with_hardware_wallet function.
For the second point we should rework the way we sign masp transactions since at the moment we sign them after having generated them and before calling sign_tx (meaning we sign them even if we dump the transaction).

While addressing the points here above we should also see if it is possible to share more code between the sign_tx function and the generate_tx_signatures one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant