Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-bug(multiple): are color variants still supported? #30246

Open
json-derulo opened this issue Dec 29, 2024 · 1 comment
Open

docs-bug(multiple): are color variants still supported? #30246

json-derulo opened this issue Dec 29, 2024 · 1 comment
Labels
docs This issue is related to documentation needs triage This issue needs to be triaged by the team

Comments

@json-derulo
Copy link
Contributor

Documentation Feedback

In v18, there used to be a section in the theming guide about creating custom color variants: https://v18.material.angular.io/guide/theming#using-component-color-variants

In v19, this section is gone. The problem is that in various component's API docs, such as button, there is still a link to this section: https://material.angular.io/components/button/api

So is this approach still supported? If yes, please bring back the section to the theming guide so the links work again. If not, please remove the link and guide to an alternative solution.

Affected documentation page

https://material.angular.io/guide/theming#using-component-color-variants

@json-derulo json-derulo added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Dec 29, 2024
@benelliott
Copy link
Contributor

benelliott commented Jan 3, 2025

To add to this, if that documentation was intentionally removed, it would be nice to restore some of it (including the class examples) to the M2-M3 migration docs (https://material.angular.io/guide/material-2-theming#optional-add-backwards-compatibility-styles-for-color-variants). Currently they just state

We recommend not relying on the color="primary", color="accent", or color="warn" options that are offered by a number of Angular Material components for M2 themes.

Without saying what to do instead (i.e. the class/mixin approach).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is related to documentation needs triage This issue needs to be triaged by the team
Projects
None yet
Development

No branches or pull requests

2 participants