You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are the following issues in the buildscript modules:
Big functions. Their contents are difficult to read and analyze even with commented blocks. Consider splitting them or even extracting into new classes.
Missing code style consistency:
a. Simple exceptions vs. Results which are better to be used in Kotlin.
b. Kotlin extensions (to make the code inside Gradle Plugins resemble build.gradle(.kts) files) vs. injected instances of configuring classes.
Complicated chains from higher levels to underlying implementations. Consider Clean Architecture for Gradle's build scripts? This is especially actual for resource-wrappers:
a. Possibly it's better to use different model classes for different layers of it.
b. Resources' paths seem to be passing in an excessive form.
Lack of optimizations. There are memory warnings appearing time to time when building frontend-example. Try to reorganize the logic of resource-wrappers to make it process resources sequentially instead of collecting metadata for all of them greedily.
Create separate issues for each of points above if needed.
The text was updated successfully, but these errors were encountered:
There are the following issues in the buildscript modules:
a. Simple exceptions vs.
Result
s which are better to be used in Kotlin.b. Kotlin extensions (to make the code inside Gradle
Plugin
s resemble build.gradle(.kts) files) vs. injected instances of configuring classes.a. Possibly it's better to use different model classes for different layers of it.
b. Resources' paths seem to be passing in an excessive form.
Create separate issues for each of points above if needed.
The text was updated successfully, but these errors were encountered: