Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (rewrite) Gradle build scripts #3

Open
andrew-k-21-12 opened this issue Jul 11, 2024 · 0 comments
Open

Refactor (rewrite) Gradle build scripts #3

andrew-k-21-12 opened this issue Jul 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@andrew-k-21-12
Copy link
Owner

andrew-k-21-12 commented Jul 11, 2024

There are the following issues in the buildscript modules:

  1. Big functions. Their contents are difficult to read and analyze even with commented blocks. Consider splitting them or even extracting into new classes.
  2. Missing code style consistency:
    a. Simple exceptions vs. Results which are better to be used in Kotlin.
    b. Kotlin extensions (to make the code inside Gradle Plugins resemble build.gradle(.kts) files) vs. injected instances of configuring classes.
  3. Complicated chains from higher levels to underlying implementations. Consider Clean Architecture for Gradle's build scripts? This is especially actual for resource-wrappers:
    a. Possibly it's better to use different model classes for different layers of it.
    b. Resources' paths seem to be passing in an excessive form.
  4. Lack of optimizations. There are memory warnings appearing time to time when building frontend-example. Try to reorganize the logic of resource-wrappers to make it process resources sequentially instead of collecting metadata for all of them greedily.

Create separate issues for each of points above if needed.

@andrew-k-21-12 andrew-k-21-12 added the enhancement New feature or request label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant