Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All numbers parsed as mobile for Argentina #29

Open
djanowski opened this issue Aug 23, 2013 · 1 comment
Open

All numbers parsed as mobile for Argentina #29

djanowski opened this issue Aug 23, 2013 · 1 comment

Comments

@djanowski
Copy link

Hi,

I noticed that all Argentinean numbers are parsed as mobile. This is visible when asking for their internationalFormat -- you always get the format for calling mobile phones from abroad.

I'm new to phone parsing in general, but I reviewed the code and it doesn't seem that you're acknowledging the fixedLine and mobile elements in the XML, so maybe this is an issue for other countries as well (for example, Mexico also has a special format for calling mobile lines from outside of the country).

In my opinion, being able to tell apart landlines and mobiles and formatting them correctly is key. Are you interested in addressing the issue?

@andreasgal
Copy link
Owner

We would take a patch for that. It didn't seem critical at the time, but it would be an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants