Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to parse output of smartctl analysis command #1

Open
sukhbir-singh opened this issue Jun 26, 2019 · 2 comments
Open

Better way to parse output of smartctl analysis command #1

sukhbir-singh opened this issue Jun 26, 2019 · 2 comments

Comments

@sukhbir-singh
Copy link
Member

Right now, this plugin works well for smartctl version 6.5. But there exists the latest version of smartctl i.e. version 7 and it is default version in fedora 29.

So we need to update parsing of smartctl output. Here, the problem is with each new version parsing needs to be changed little bit by observing the smartctl output. We can deal with this problem by using --json flag that is introduced in latest version of smartctl and so using this parsing would be easier and more robust.

@cpg
Copy link
Member

cpg commented Jun 26, 2019

Can we do it in a backwards-compatible way?

@sukhbir-singh
Copy link
Member Author

Yes. We can easily check version of smartctl installed and accordingly we can choose either to use standard parsing technique or json parsing.
Json flag option is only available in latest version 7 of smartctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants