A collection of errors #3
Comments
|
Hi, Thanks for the reports. I'll take a look at the XML output, but it probably won't be very useful to diagnose the 1st and 3rd problems. It would be easier if I had minimal working examples with input and output. Regarding the "hot" example, it seems that the quotes in the node heading are causing a problem, but I haven't been able to figure out why. It seems that Graphviz is putting out valid SVG XML, and when I load that SVG XML into an Emacs buffer and For example, this is the XML after Emacs parses and prints it again: <top>
<comment> Generated by graphviz version 2.36.0 (20140111.2315)
</comment>
<comment> Title: orggraphview Pages: 1
</comment>
<svg width="576pt" height="263pt" viewBox="0.00 0.00 576.00 263.10">
<g id="graph0" class="graph" transform="scale(0.145507 0.145507) rotate(0) translate(4 1804.16)">
<title> orggraphview
</title>
<polygon fill="#0c0a20" stroke="none" points="-4,4 -4,-1804.16 3954.58,-1804.16 3954.58,4 -4,4">
</polygon>
<comment> node224
</comment>
<g id="node1" class="node">
<title> node224
</title>
<g id="a_node1">
<a href="224" title="Screenshots "test" quote">
<text text-anchor="middle" x="771.5" y="-1342.3" font-family="DejaVu Sans Mono" font-size="14.00" fill="#1da7fb"> Screenshots "test" quote
</text>
</a>
</g>
</g>You can see the lack of escaping in the <?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<!-- Generated by graphviz version 2.36.0 (20140111.2315)
-->
<!-- Title: orggraphview Pages: 1 -->
<svg width="576pt" height="263pt"
viewBox="0.00 0.00 576.00 263.10" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<g id="graph0" class="graph" transform="scale(0.145507 0.145507) rotate(0) translate(4 1804.16)">
<title>orggraphview
</title>
<polygon fill="#0c0a20" stroke="none" points="-4,4 -4,-1804.16 3954.58,-1804.16 3954.58,4 -4,4"/>
<!-- node224 -->
<g id="node1" class="node">
<title>node224
</title>
<g id="a_node1">
<a xlink:href="224" xlink:title="Screenshots "test" quote">
<text text-anchor="middle" x="771.5" y="-1342.3" font-family="DejaVu Sans Mono" font-size="14.00" fill="#1da7fb">Screenshots "test" quote
</text>
</a>
</g>
</g>I don't know if there's a bug in Emacs, or libxml, or something else. It doesn't matter whether I escape the quotes or replace them with HTML entities ( I guess I'll have to work around it by removing quotes from headings for now. Any ideas or help with fixing this problem would be appreciated. |
|
I guess you added that MWE while I wasn't looking. ;) Unfortunately, it works for me:
$ dot -V
dot - graphviz version 2.36.0 (20140111.2315)
# Emacs 26.3The Graphviz version on my system is much older, but with such a simple file, I wouldn't expect it to be a problem. I wonder if your Emacs is able to parse or display SVG files at all. Is it compiled with ImageMagick support? Can you try to find a known-good SVG image, load it into an XML buffer, and use |
|
I know that my emacs is able to display to display SVG images as it has (may times) in the past with the form If it helps, here is a full list of features my emacs has enabled:
|
|
It appears that your Emacs wasn't built with ImageMagick. Here's mine: I added a check to try to warn when this is the case: 20a572e Please let me know what happens when you use the current version of the code. |
|
Now I get something much better than it just not working As an asside, I'm not sure why imagemagick is needed. Would you mind explaining? |
|
That's what Emacs uses to work with images. |
|
That's funny, I haven't had any issues with images ¯\(ツ)/¯. When Emacs moves to Cairo in 27 will this be reflected in this package? |
|
I don't know. I didn't design Emacs's image features. All I know is that it is required for some operations involving images, and AFAIK Emacs is intended to be built with ImageMagick support by default, so if yours isn't, you should take that up with whoever built the package for you--in your case, Solus Linux, I guess. Emacs in Debian and other mainstream distros has ImageMagick support by default. AFAIK Cairo has nothing to do with this. |
|
Sure :) just based on me hearing that in 27 emacs will replace imagemagik with cairo. |
|
|
|
Same here, I care far more that it does it than how. I'll probably just wait till E27 releases (apparently soon), then ping my maintainers. Once I'm running that I'll come back here and see if it works. |
|
I just get the "This emacs doesn't have ImageMagick" message ATM |
|
Thanks. Would it be possible for you to comment out that check in the code and test again? Maybe ImageMagick isn't required anymore, but I can't be sure unless someone who doesn't have it tests it. |
|
😅 I'll do that |
|
It works! Just not as nicely as the demo
|
|
Any idea what might be needed to get this completely working for me? |
|
What exactly is the problem? |
|
Only part of the graph fits in the buffer. It seems like the graph assumes it's going to be in a vertical split, but when I call the command it appears in a horizontal split. This is what I see immediately after calling the command:
And then if I expand the buffer, stuff is cut off If I create a vertical split, I see an empty buffer. If I click in the buffer I see this |
|
The relevant code starts here: org-graph-view/org-graph-view.el Lines 179 to 183 in 1331433 Given that you're using Emacs 27 and Doom, it's hard to say what's going on. I don't think the code should be specific to horizontal splits (note that Emacs uses the opposite term than what you might expect: "vertical split" means one buffer above another, not that the divider is oriented vertically), because it just calls So the first thing to do is to try to reproduce using An idea that came to mind is to insert a call to |
|
Ok. I'll see if I can find anything from that. One small thing, I'm on emacs 26.3 not 27 😛 |
|
Ok, I thought those tabs were from Emacs 27. So whatever is going on with window management in that config is likely to make a difference, and that would be out-of-scope for this package to mess with. Anyway, let me know. Thanks. |
|
Hi! What exactly did you comment out in the code? I may be running into the same issue. |
Hello! I've run into a few issues,
I tried to use this on my literate config file, didn't quite like it though.
From *messages*
Then I tried another file, and I got a different issue
From the statusline
For reference "hot" appears on two (consecutive) lines
From *messages*
Then I tried a 3rd file and got a similar error to the first time
At this point I gave up. The gif looks really cool! I hope you can get this working.
A quick MWE
As a quick test I tried the following, which also didn't work
Let me know what else I should test 🙂.
System info
The text was updated successfully, but these errors were encountered: