-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments with null points and different order than HN #206
Comments
Is this project still maintained? |
cc @Haroenv anyone that could take a look at this? |
Hi @ig-perez @JonasBa, the issue in the initial comment seems to be fixed (both link show the same number of points). @pierregoutheraud could you elaborate? Do you have an example where it's not working? Selecting "Comments" and leaving the default sorting "Popularity" seems to work (tried searching as well): |
Cool, thanks @julienpa . @pierregoutheraud feel free to close the issue if works for you as well. Best, |
@julienpa When sorting comments by popularity "All time" time range works but any other time range returns the same results: Screen.Recording.2022-10-03.at.23.26.22.movThis might be because hackernews api does not return the score for comments anymore. |
Hi,
Thanks for maintaing this repo. I have noticed comments from a given item return with
points: null
, probably this is causing the comments are not returned in the same order as when querying HN. For example:https://hn.algolia.com/api/v1/items/26750452
https://news.ycombinator.com/item?id=26750452
Thanks
The text was updated successfully, but these errors were encountered: