When updating related entities, Eloquent events such as saved and updated are NOT fired.

[sto-calcueasy]

Hi Alfa,

This is Stefan. This is my first time submitting an issue for your package.

The problem

When using the update() method without retrieving the entity first, the Laravel events updating, updated, saving and saved are not fired. I noticed this when I was working on an Event for my application and I was wondering why the saved event was only fired when a new related entity is added, but it is not fired when an existing entity is edited.

laravel-hasmany-sync/src/ServiceProvider.php

Lines 75 to 76 in 16aac13

	$this->getRelated()->where($relatedKeyName, $castKey(array_get($row, $relatedKeyName)))
	->update($row);

The reason why saved event is fired when a new related entity is added is because createMany method is used.

laravel-hasmany-sync/src/ServiceProvider.php

Line 68 in 16aac13

$newRecords = $this->createMany($newRows);

Possible solution?

I would solve the issue by replacing the use of update method with

$related = $this->getRelated()
                    ->where($relatedKeyName, $castKey(array_get($row, $relatedKeyName)))
                    ->first()
                    ->fill($row)
                    ->save();

Literature

https://laravel.com/docs/8.x/eloquent#updates
https://stackoverflow.com/questions/41295032/laravel-eloquent-model-update-event-is-not-fired

What do you think?

Please let me know what do you think. If you are not OK with the change, would it be OK for me to make a fork?

Thank you very much for the package. It is really handy.

Best regards!

[korridor]

@sto-calcueasy This repository has been inactive for a while. I created a fork that can be installed directly with composer, works with newer Laravel version and added unit tests.
Link to the fork: https://github.com/korridor/laravel-has-many-sync

I also corrected the problem that you are referring to for updates.