Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out REST proxy #109

Open
alexbosworth opened this issue Nov 30, 2019 · 4 comments
Open

Abstract out REST proxy #109

alexbosworth opened this issue Nov 30, 2019 · 4 comments

Comments

@alexbosworth
Copy link
Owner

The original REST proxy mode has some problems, needed fixes:

  1. Abstract out and fill in all REST translations
  2. Add HMAC based authentication option
  3. Add a proxy call that allows simply tunneling gRPC calls through REST
@dennisreimann
Copy link
Contributor

Regarding point 3: I've experimented with that in a project of mine where I'm also using ln-service. I've written up some more on the approach here and maybe you find this interesting – relevant part here.

@alexbosworth
Copy link
Owner Author

Looks great

This is how ln-service started originally before I switched it to focus on gRPC. I think REST is more natural and flexible for a lot of people, including myself before I adapted my stuff to gRPC

@alexbosworth
Copy link
Owner Author

I've created an alternative to the REST proxy that I think can serve as a successor: https://github.com/alexbosworth/lightning/tree/master/lnd_gateway

The big difference though is that I don't really do REST with this, it's more of a direct proxy to the gRPC. That helps ensure that the REST requests would have total feature parity with gRPC requests

@dennisreimann
Copy link
Contributor

Nice, I‘ll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants