Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prices reset to 0$ after last update #127

Open
Bloodlex opened this issue Oct 21, 2022 · 5 comments
Open

Prices reset to 0$ after last update #127

Bloodlex opened this issue Oct 21, 2022 · 5 comments

Comments

@Bloodlex
Copy link

Bloodlex commented Oct 21, 2022

Hey,

After the last 3.4.2 update, many of my regions changed price to 0$ (mostly polygonal ones if that is important), although they had been created previously with autoprice. And creating sign once again with autoprice still doesn't change it.

For now I rolled back to previous version.

Do you have any idea why it could be so?

Thanks for your help.

Best regards,
Bloodlex

@alex9849
Copy link
Owner

Not really. Maybe the calculations for volumes break in the newest version. I'll need to check that :)

@Bloodlex
Copy link
Author

Not really. Maybe the calculations for volumes break in the newest version. I'll need to check that :)

I'd be grateful if you could, thanks a lot 🙂

@TheClowner
Copy link

I'm running into this issue myself now, any poly regions just don't calculate a volume - probably since worldguard's .volume() method for poly regions just returns 0 - https://github.com/EngineHub/WorldGuard/blob/20044a72d3f5bd3d6a6a2f1e00e0b7307789bb48/worldguard-core/src/main/java/com/sk89q/worldguard/protection/regions/ProtectedPolygonalRegion.java#L186

I guess maybe ARM used to calculate the volume itself?

@Emix33
Copy link

Emix33 commented Aug 13, 2023

This "regression"? seems to have occured in commit 2e9d06e , Before this commit Arm did indeed workaround the worldguard bug by calculating the volume for polygonal regions itself. I dont know why this was changed, or if it was intentional.

@Bloodlex
Copy link
Author

Bloodlex commented Sep 3, 2023

This "regression"? seems to have occured in commit 2e9d06e , Before this commit Arm did indeed workaround the worldguard bug by calculating the volume for polygonal regions itself. I dont know why this was changed, or if it was intentional.

Yes, it worked before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants