Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating window border #15

Open
chris977 opened this issue Jul 29, 2024 · 3 comments
Open

Floating window border #15

chris977 opened this issue Jul 29, 2024 · 3 comments
Labels
feature New feature or request

Comments

@chris977
Copy link

Expected behavior

Floating windows should have the border color and width configured in .config/river/init

Actual behavior

A floating window displays the river default border at login or inherits the border (or lack of it) from the previous tag.

Steps to reproduce

At login open a floating window in the first tag. The window has a 2px border with the color #93A1A1 (the river default if other values are not specified). Open a tiling window in tag 2, the window has no borders. Switch back to tag 1, the floating window has now no borders. Open 2 windows in tag 3, the windows have each a 1px border with the configured colors, as expected. Switch back to tag 1, the floating window has now a 1px border with the configured #285577 color.

river version

0.3.4

wideriver version

1.2.0

Startup logs

I [11:10:34] --layout                       left
I [11:10:34] --layout-alt                   monocle
I [11:10:34] --stack                        even
I [11:10:34] --count-master                 1
I [11:10:34] --ratio-master                 0.5
I [11:10:34] --count-wide-left              0
I [11:10:34] --ratio-wide                   0.5
I [11:10:34] --smart-gaps
I [11:10:34] --inner-gaps                   0
I [11:10:34] --outer-gaps                   0
I [11:10:34] --border-width                 1
I [11:10:34] --border-width-monocle         0
I [11:10:34] --border-width-smart-gaps      0
I [11:10:34] --border-color-focused         0x285577
I [11:10:34] --border-color-focused-monocle 0xB48EAD
I [11:10:34] --border-color-unfocused       0x4C566A
I [11:10:34] --log-threshold                info
I [11:10:34] wideriver started
@chris977 chris977 added the bug Something isn't working label Jul 29, 2024
@alex-courtis
Copy link
Owner

Honestly, I did not consider floating windows; they're not something I use.

Right now it is not possible to set individual borders per window.

It may be possible to set an alternate border scheme when there is a floating window. Detect this via the river status protocol or however lswt does it, looks like wayland protocol.

@alex-courtis
Copy link
Owner

alex-courtis commented Aug 3, 2024

Draft:

I [11:10:34] --border-width-float         3
I [11:10:34] --border-color-focused-float 0xABBCC
I [11:10:34] --border-color-unfocused       0x4C566A

@Anachron
Copy link

I would love to have this feature as well.

Floating Windows are great for sticking views.

@alex-courtis alex-courtis added feature New feature or request and removed bug Something isn't working labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants