fix: fix markdown page link redirect

alephjs · Oct 14, 2020 · 0b1ab39 · 0b1ab39
1 parent 487c2c0
commit 0b1ab39
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/aleph.ts b/aleph.ts
@@ -207,6 +207,10 @@ export function ALEPH({ initial }: {
 export async function redirect(url: string, replace?: boolean) {
     const { location, history } = window as any
 
+    if (!util.isNEString(url)) {
+        return
+    }
+
     if (util.isHttpUrl(url)) {
         location.href = url
         return

diff --git a/project.ts b/project.ts
@@ -855,12 +855,13 @@ export class Project {
                     `    const appLinks = [];`,
                     `    const onClick = e => {`,
                     `      e.preventDefault();`,
-                    `      redirect(e.target.getAttribute("href"));`,
+                    `      redirect(e.currentTarget.getAttribute("href"));`,
                     `    };`,
                     `    if (ref.current) {`,
                     `      ref.current.querySelectorAll("a").forEach(a => {`,
-                    `        if (!/^(https?|mailto|file):/i.test(a.getAttribute("href"))) {`,
-                    `          a.addEventListener("click", onClick);`,
+                    `        const href = a.getAttribute("href")`,
+                    `        if (href && !/^(https?|mailto|file):/i.test(href)) {`,
+                    `          a.addEventListener("click", onClick, false);`,
                     `          appLinks.push(a);`,
                     `        }`,
                     `      });`,