Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional profiles #20

Open
flat1984 opened this issue Jan 3, 2025 · 2 comments
Open

Support for additional profiles #20

flat1984 opened this issue Jan 3, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@flat1984
Copy link
Contributor

flat1984 commented Jan 3, 2025

Hi, this HA-addon looks very promising. As I understand, there are currently 3 pyhafas profiles supported: DBProfile, KVBProfile, VSNProfile.

If I look at the profiles provided in the pyhafas-repository, there are a few more already implemented:
https://github.com/FahrplanDatenGarten/pyhafas/tree/main/pyhafas/profile

What does it need to get them also included? I would especially be interested to help with NASA.

@akloeckner
Copy link
Owner

Yes, those are the three profiles we were personally interested in originally. And we said, we would accept more profiles as soon as someone asks for them.

There are basically two places, where they will need to be added:

  • config_flow.py and
  • __init__.py.

See this search:
https://github.com/search?q=repo%3Aakloeckner%2Fhacs-hafas%20kvb&type=code

If you could propose a PR, I think it will be straightforward to merge it.

@akloeckner
Copy link
Owner

See #26 for a good example.

@akloeckner akloeckner added the enhancement New feature or request label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants