-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathconfig.json
408 lines (408 loc) · 31.5 KB
/
config.json
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
{
"client_name": "Indexed Finance",
"commit_hash": "e3b2bed80e1c467b04d1d6121c06ddfc2e751fb6",
"date": "February 2021",
"date_interval": "February 11, 2021",
"issues": [
{
"active_lock_reason": null,
"assignee": null,
"assignees": [],
"author_association": "MEMBER",
"body": "",
"closed_at": "2021-02-16T10:25:57Z",
"comments": 0,
"comments_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/7/comments",
"created_at": "2021-02-16T09:58:12Z",
"events_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/7/events",
"html_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/pull/7",
"id": 809160667,
"labels": [],
"labels_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/7/labels{/name}",
"locked": false,
"milestone": null,
"node_id": "MDExOlB1bGxSZXF1ZXN0NTc0MDY5NzM0",
"number": 7,
"performed_via_github_app": null,
"pull_request": {
"diff_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/pull/7.diff",
"html_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/pull/7",
"patch_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/pull/7.patch",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/pulls/7"
},
"repository_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02",
"state": "closed",
"title": "Surya, sol2uml, tests output",
"updated_at": "2021-02-16T10:25:57Z",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/7",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/342638?v=4",
"events_url": "https://api.github.com/users/andreiashu/events{/privacy}",
"followers_url": "https://api.github.com/users/andreiashu/followers",
"following_url": "https://api.github.com/users/andreiashu/following{/other_user}",
"gists_url": "https://api.github.com/users/andreiashu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/andreiashu",
"id": 342638,
"login": "andreiashu",
"node_id": "MDQ6VXNlcjM0MjYzOA==",
"organizations_url": "https://api.github.com/users/andreiashu/orgs",
"received_events_url": "https://api.github.com/users/andreiashu/received_events",
"repos_url": "https://api.github.com/users/andreiashu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/andreiashu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andreiashu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/andreiashu"
}
},
{
"active_lock_reason": null,
"assignee": null,
"assignees": [],
"author_association": "MEMBER",
"body": "**Description**\r\n\r\nTo run a transaction, it first needs to be queued by calling `queueTransaction`.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L116-L122\r\n\r\nThe arguments are encoded, and the resulting byte string is hashed as `txHash`.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L128\r\n\r\nThe `txHash` is then marked as queued in a `queuedTransactions` mapping.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L129\r\n\r\nWhen queuing transactions, the only check relates to the `eta` to ensure enough delay until the transaction can be executed.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L123-L126\r\n\r\nAt the end of the `queueTransaction` method, an event is emitted with the provided parameters.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L131\r\n\r\nEven if the transaction was already queued, an event would be emitted. Thus, an admin could queue multiple times the same transaction but execute it only once. Each time the transaction is queued, an event is omitted. But only one `ExecuteTransaction` event will be emitted when the transaction is executed.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L221\r\n\r\nA web interface could become desynchronized if it reads multiple `QueueTransaction` events but only one matching `ExecuteTransaction` event.\r\n\r\n**Recommendation**\r\n\r\nAdd a check in the method `queueTransaction` to ensure the transaction was not already queued before queueing the transaction.\r\n\r\n```solidity\r\nrequire(queuedTransactions[txHash] == false, \"CommitteeTimelock::queueTransaction: Transaction already queued.\")\r\n```\r\n",
"closed_at": "2021-02-18T07:10:33Z",
"comments": 1,
"comments_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/6/comments",
"created_at": "2021-02-16T07:58:22Z",
"events_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/6/events",
"html_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/6",
"id": 809078581,
"labels": [
{
"color": "FFCC00",
"default": false,
"description": null,
"id": 2731084062,
"name": "Minor",
"node_id": "MDU6TGFiZWwyNzMxMDg0MDYy",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Minor"
},
{
"color": "667788",
"default": false,
"description": null,
"id": 2731083981,
"name": "Report",
"node_id": "MDU6TGFiZWwyNzMxMDgzOTgx",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Report"
}
],
"labels_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/6/labels{/name}",
"locked": false,
"milestone": null,
"node_id": "MDU6SXNzdWU4MDkwNzg1ODE=",
"number": 6,
"performed_via_github_app": null,
"repository_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02",
"state": "closed",
"title": "[CommitteeTimelock] - Emits event even if the transaction was already queued",
"updated_at": "2021-02-18T07:10:33Z",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/6",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/547012?v=4",
"events_url": "https://api.github.com/users/cleanunicorn/events{/privacy}",
"followers_url": "https://api.github.com/users/cleanunicorn/followers",
"following_url": "https://api.github.com/users/cleanunicorn/following{/other_user}",
"gists_url": "https://api.github.com/users/cleanunicorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cleanunicorn",
"id": 547012,
"login": "cleanunicorn",
"node_id": "MDQ6VXNlcjU0NzAxMg==",
"organizations_url": "https://api.github.com/users/cleanunicorn/orgs",
"received_events_url": "https://api.github.com/users/cleanunicorn/received_events",
"repos_url": "https://api.github.com/users/cleanunicorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cleanunicorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cleanunicorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cleanunicorn"
}
},
{
"active_lock_reason": null,
"assignee": null,
"assignees": [],
"author_association": "MEMBER",
"body": "**Description**\r\n\r\nIn the `CommitteeTimelock` contract, an admin or a superUser can queue an execution by calling `queueTransaction`.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L116-L122\r\n\r\nThe arguments are packed together using `abi.encode`, and a `keccak256` is applied on top of the encoding.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L128\r\n\r\nThe computed `txHash` is then saved in a mapping named `queuedTransactions`.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L67\r\n\r\nThe execution can be run by calling `executeTransaction` and specifying again all of the necessary arguments (previously used to compute `txHash`).\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L148-L154\r\n\r\nIf the queued execution passes all checks, it will be run, by internally calling `_executeTransaction`.\r\n\r\nThe internal method `_executeTransaction` checks if a function signature was provided, and if none exists, it assumes the `bytes memory data` already contains the function selector.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/858ff477bdacb4a32e5b1f5e6bac122e25581992/code/contracts/committee/CommitteeTimelock.sol#L209-L213\r\n\r\nThis means that for the same execution, 2 different `txHashes` can exist, one with the `signature` specified, the other one with the signature contained in the `data` argument.\r\n\r\nNot only 2 different `txHashes` can exist for the same execution (because the signature can be included in the `data` argument), but also ABI encoding makes it possible to decode multiple different byte arrays to the same arguments. This is possible because but not only:\r\n- ABI encoding is not very strict\r\n- Solidity accepts garbage data after all needed arguments were successfully parsed\r\n- Address arguments are enclosed in 32 bytes, but only 20 bytes are significant, the first 12 bytes are erased when Solidity parses that argument; any bytes within the 12 bytes will change the hash, but not change the execution\r\n- Strings have a length attached but enclosed in 32-byte blocks; any bytes after the specified length are ignored\r\n\r\n",
"closed_at": "2021-02-18T07:13:26Z",
"comments": 2,
"comments_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/5/comments",
"created_at": "2021-02-15T15:02:30Z",
"events_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/5/events",
"html_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/5",
"id": 808609531,
"labels": [
{
"color": "34C759",
"default": false,
"description": null,
"id": 2731084016,
"name": "Informational",
"node_id": "MDU6TGFiZWwyNzMxMDg0MDE2",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Informational"
},
{
"color": "667788",
"default": false,
"description": null,
"id": 2731083981,
"name": "Report",
"node_id": "MDU6TGFiZWwyNzMxMDgzOTgx",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Report"
}
],
"labels_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/5/labels{/name}",
"locked": false,
"milestone": null,
"node_id": "MDU6SXNzdWU4MDg2MDk1MzE=",
"number": 5,
"performed_via_github_app": null,
"repository_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02",
"state": "closed",
"title": "[CommitteeTimelock] - The computed `txHash` should not be considered unique for an execution",
"updated_at": "2021-02-18T07:13:26Z",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/5",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/547012?v=4",
"events_url": "https://api.github.com/users/cleanunicorn/events{/privacy}",
"followers_url": "https://api.github.com/users/cleanunicorn/followers",
"following_url": "https://api.github.com/users/cleanunicorn/following{/other_user}",
"gists_url": "https://api.github.com/users/cleanunicorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cleanunicorn",
"id": 547012,
"login": "cleanunicorn",
"node_id": "MDQ6VXNlcjU0NzAxMg==",
"organizations_url": "https://api.github.com/users/cleanunicorn/orgs",
"received_events_url": "https://api.github.com/users/cleanunicorn/received_events",
"repos_url": "https://api.github.com/users/cleanunicorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cleanunicorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cleanunicorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cleanunicorn"
}
},
{
"active_lock_reason": null,
"assignee": null,
"assignees": [],
"author_association": "MEMBER",
"body": "**Description**\r\n\r\nThe newly elected Sigma Committee will have the ability to assign rewards for liquidity mining on new pools. To do this, any new distribution will have to go through a 7 day timelock - in theory, this gives NDX token holders 3 days to veto a token allocation: \r\n\r\n* Committee timelock has a 7 days execution delay\r\n* GovernorAlpha has a 3 day voting period\r\n* Indexed timelock has a 2 day execution delay\r\n\r\nCompared to Indexed and Committee timelocks, which measure time in days, [GovernorAlpha.sol](https://github.com/indexed-finance/governance/blob/7473af351c9c38d12bb3741023b749442ef8d763/contracts/governance/GovernorAlpha.sol#L12-L13) measures time as the number of blocks mined since the start of a vote and assumes a block is mined every 15 seconds:\r\n\r\n```solidity\r\n /// @dev The voting period which will be set after setVotingPeriodAfter has passed.\r\n uint256 public constant permanentVotingPeriod = 17_280; // ~3 days in blocks (assuming 15s blocks)\r\n```\r\n\r\nCurrently, we have the following average block times (source [etherscan data](https://etherscan.io/chart/blocktime)):\r\n* past 12 months: avg 13.11 seconds (range of minimum: 12.83 / maximum: 13.53 seconds)\r\n* past 3 months: avg 13.08 seconds\r\n\r\nTaking the past 3 months as a point of reference we get the following figures:\r\n\r\n<img width=\"332\" alt=\"Screenshot 2021-02-12 at 15 46 07\" src=\"https://user-images.githubusercontent.com/342638/107747075-76511e80-6d49-11eb-8343-38afe1cb29c1.png\">\r\n\r\nThis means that, in reality, NDX token holders currently have 2.6 days or just under 63 hours to pass a vote to veto a token allocation. This difference can confuse and potentially stop some users from acting in time to veto proposals if not properly communicated.\r\n\r\n**Recommendation**\r\n\r\nIt might be worth ensuring that users understand that the voting period is less than 3 days so that they don't miss out on vetoing undesirable proposals.\r\n\r\nAlternatively, expressing the time intervals as timestamps will ensure the time intervals are precise and predictable.\r\n\r\n",
"closed_at": "2021-02-18T07:14:45Z",
"comments": 0,
"comments_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/4/comments",
"created_at": "2021-02-12T08:56:05Z",
"events_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/4/events",
"html_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/4",
"id": 807060590,
"labels": [
{
"color": "007AFF",
"default": false,
"description": null,
"id": 2731084192,
"name": "Acknowledged",
"node_id": "MDU6TGFiZWwyNzMxMDg0MTky",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Acknowledged"
},
{
"color": "FF9500",
"default": false,
"description": null,
"id": 2731084119,
"name": "Medium",
"node_id": "MDU6TGFiZWwyNzMxMDg0MTE5",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Medium"
},
{
"color": "667788",
"default": false,
"description": null,
"id": 2731083981,
"name": "Report",
"node_id": "MDU6TGFiZWwyNzMxMDgzOTgx",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Report"
}
],
"labels_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/4/labels{/name}",
"locked": false,
"milestone": null,
"node_id": "MDU6SXNzdWU4MDcwNjA1OTA=",
"number": 4,
"performed_via_github_app": null,
"repository_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02",
"state": "closed",
"title": "The voting period is shorter than 3 days",
"updated_at": "2021-02-18T08:39:10Z",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/4",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/342638?v=4",
"events_url": "https://api.github.com/users/andreiashu/events{/privacy}",
"followers_url": "https://api.github.com/users/andreiashu/followers",
"following_url": "https://api.github.com/users/andreiashu/following{/other_user}",
"gists_url": "https://api.github.com/users/andreiashu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/andreiashu",
"id": 342638,
"login": "andreiashu",
"node_id": "MDQ6VXNlcjM0MjYzOA==",
"organizations_url": "https://api.github.com/users/andreiashu/orgs",
"received_events_url": "https://api.github.com/users/andreiashu/received_events",
"repos_url": "https://api.github.com/users/andreiashu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/andreiashu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andreiashu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/andreiashu"
}
},
{
"active_lock_reason": null,
"assignee": null,
"assignees": [],
"author_association": "MEMBER",
"body": "**Description**\r\n\r\nThe `CommitteeTimelock` is defined as an extension of the `ICommitteeTimelock` interface. The interface defines a set of events.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/ed374bd8bbd948f78a4661182092c6c0a90baec9/code/contracts/interfaces/ICommitteeTimelock.sol#L5-L31\r\n\r\nAnd the `CommitteeTimelock` implementation redefines the same set of events.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/blob/ed374bd8bbd948f78a4661182092c6c0a90baec9/code/contracts/committee/CommitteeTimelock.sol#L21-L47\r\n\r\nThis isn't necessary, and the event definition can be omitted in the implementation. This also protects from defining almost the same event with different arguments, or typos.\r\n\r\nSolidity allows the definition and the emission of events that share the same name but have a different `topic` and arguments.\r\n\r\ni.e.,\r\n\r\n```solidity\r\ninterface IWithEvent {\r\n event TheEvent(uint n);\r\n}\r\n\r\ncontract we is IWithEvent {\r\n event TheEvent(string n);\r\n \r\n function emitEvent() public {\r\n emit TheEvent(block.number);\r\n emit TheEvent(\"something else\");\r\n }\r\n}\r\n```\r\n\r\n`emitEvent()` will emit 2 very diffent events.\r\n\r\n```json\r\n[\r\n {\r\n \"from\": \"0x358AA13c52544ECCEF6B0ADD0f801012ADAD5eE3\",\r\n \"topic\": \"0xd3d703951f7bff25f2e2896e97ba52c506eb73af2e72a1bd8bd2944e596609f8\",\r\n \"event\": \"TheEvent\",\r\n \"args\": {\r\n \"0\": \"7\",\r\n \"n\": \"7\"\r\n }\r\n },\r\n {\r\n \"from\": \"0x358AA13c52544ECCEF6B0ADD0f801012ADAD5eE3\",\r\n \"topic\": \"0x5286c814765d3cf19bf3c71af4bd8d4b1b3a7c6e748b608da0d23b4f83801ed4\",\r\n \"event\": \"TheEvent\",\r\n \"args\": {\r\n \"0\": \"something else\",\r\n \"n\": \"something else\"\r\n }\r\n }\r\n]\r\n```\r\n\r\n**Recommendation**\r\n\r\nRemove the event definition from the `CommitteeTimelock` implementation which should leave you with the events defined in the interface `ICommitteeTimelock`.\r\n\r\n",
"closed_at": "2021-02-18T07:13:54Z",
"comments": 1,
"comments_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/2/comments",
"created_at": "2021-02-11T13:07:02Z",
"events_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/2/events",
"html_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/2",
"id": 806373063,
"labels": [
{
"color": "FFCC00",
"default": false,
"description": null,
"id": 2731084062,
"name": "Minor",
"node_id": "MDU6TGFiZWwyNzMxMDg0MDYy",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Minor"
},
{
"color": "667788",
"default": false,
"description": null,
"id": 2731083981,
"name": "Report",
"node_id": "MDU6TGFiZWwyNzMxMDgzOTgx",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Report"
}
],
"labels_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/2/labels{/name}",
"locked": false,
"milestone": null,
"node_id": "MDU6SXNzdWU4MDYzNzMwNjM=",
"number": 2,
"performed_via_github_app": null,
"repository_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02",
"state": "closed",
"title": "[CommitteeTimelock] - Can omit the events from the contract implementation",
"updated_at": "2021-02-18T07:13:54Z",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/2",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/547012?v=4",
"events_url": "https://api.github.com/users/cleanunicorn/events{/privacy}",
"followers_url": "https://api.github.com/users/cleanunicorn/followers",
"following_url": "https://api.github.com/users/cleanunicorn/following{/other_user}",
"gists_url": "https://api.github.com/users/cleanunicorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cleanunicorn",
"id": 547012,
"login": "cleanunicorn",
"node_id": "MDQ6VXNlcjU0NzAxMg==",
"organizations_url": "https://api.github.com/users/cleanunicorn/orgs",
"received_events_url": "https://api.github.com/users/cleanunicorn/received_events",
"repos_url": "https://api.github.com/users/cleanunicorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cleanunicorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cleanunicorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cleanunicorn"
}
},
{
"active_lock_reason": null,
"assignee": null,
"assignees": [],
"author_association": "MEMBER",
"body": "**Description**\r\n\r\nThe `require` error message does not mention `superUser` although it's one of the OR conditions in this modifier.\r\n\r\nhttps://github.com/monoceros-alpha/review-indexed-sigmacomittee-2021-02/blob/4c772f1edb078db49a4b441fe39e6efa6dc7f653/code/contracts/committee/CommitteeTimelock.sol#L59-L65\r\n\r\n**Recommendation**\r\n\r\nUpdate the error message to: `Call must come from admin or superUser.`\r\n\r\n",
"closed_at": "2021-02-18T07:14:09Z",
"comments": 1,
"comments_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/1/comments",
"created_at": "2021-02-11T02:17:39Z",
"events_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/1/events",
"html_url": "https://github.com/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/1",
"id": 806027309,
"labels": [
{
"color": "34C759",
"default": false,
"description": null,
"id": 2731084016,
"name": "Informational",
"node_id": "MDU6TGFiZWwyNzMxMDg0MDE2",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Informational"
},
{
"color": "FFCC00",
"default": false,
"description": null,
"id": 2731084062,
"name": "Minor",
"node_id": "MDU6TGFiZWwyNzMxMDg0MDYy",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Minor"
},
{
"color": "667788",
"default": false,
"description": null,
"id": 2731083981,
"name": "Report",
"node_id": "MDU6TGFiZWwyNzMxMDgzOTgx",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/labels/Report"
}
],
"labels_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/1/labels{/name}",
"locked": false,
"milestone": null,
"node_id": "MDU6SXNzdWU4MDYwMjczMDk=",
"number": 1,
"performed_via_github_app": null,
"repository_url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02",
"state": "closed",
"title": "[CommitteeTimelock] - Update `require` error message to reflect condition",
"updated_at": "2021-02-18T07:14:09Z",
"url": "https://api.github.com/repos/monoceros-alpha/review-indexed-sigmacommittee-2021-02/issues/1",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/342638?v=4",
"events_url": "https://api.github.com/users/andreiashu/events{/privacy}",
"followers_url": "https://api.github.com/users/andreiashu/followers",
"following_url": "https://api.github.com/users/andreiashu/following{/other_user}",
"gists_url": "https://api.github.com/users/andreiashu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/andreiashu",
"id": 342638,
"login": "andreiashu",
"node_id": "MDQ6VXNlcjM0MjYzOA==",
"organizations_url": "https://api.github.com/users/andreiashu/orgs",
"received_events_url": "https://api.github.com/users/andreiashu/received_events",
"repos_url": "https://api.github.com/users/andreiashu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/andreiashu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andreiashu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/andreiashu"
}
}
],
"person_days": "5",
"project_name": "Sigma Comittee",
"review_period": "3 days",
"source_repository": "https://github.com/indexed-finance/sigma-core",
"template": "./Readme.md.mustache"
}