SonarBug. LogEventManager does not decrement correctly

[sungchoi]

decrementMoveCount does not decrement moveCount

Test Plan:

• Go to sonarbug repo
• Checkout correct branch ($ git checkout V.0.0.5)
• Update SonarBug ($ git pull --rebase)
• Build Sonarbug ($ buildbug)
• Expecation: All tests should pass
• Install Sonarbug ($ npm install)
• cd into installed sonarbug directory
• cd into scripts directory
• start sonarbug server ($ forever start sonarbugserver-start.js)
• check logs ($ forever logs 0)
• Expectation: Sonarbug should start without error
• Run local version of Splash page
• open local version of splash in browers
• open several more splash pages
• Expecation: There should be the same number of log files open in the logs/active folder
• close all of the splash browser windows
• Expectation: There should be no log files open in the logs/active folder
• check logs ($ forever logs 0)
• Expectation: You should the following type of output (after the last connection has closed, not before)
  • data: sonarbugserver-start.js:29631 - EventLogManager-completed-93 dispatched event: 'ready-to-package'
  • data: sonarbugserver-start.js:29631 - successfully moved log file to completed user folder
  • data: sonarbugserver-start.js:29631 - Rotating logs...
  • data: sonarbugserver-start.js:29631 - Config file updated with new currentCompletedId: 94
  • data: sonarbugserver-start.js:29631 - Completed Folder rotated to completed-94
  • data: sonarbugserver-start.js:29631 - Logs rotated.
• Expectation: The log files mentioned above should be in the older completed folder which should now be in the logs/toPackage folder

[brianneisler]

@sungchoi can you write up a test plan for this?

[sungchoi]

@bneisler doh! (I'm on it)

[sungchoi]

@bneisler Tim could probably tackle this with a bit more instruction in the test plan. What do you think? Do you want to take this?

[brianneisler]

@sung, I agree Tim could do the basic QA here. I think I'm gonna take a first crack at this though as I'd like to dig in a bit and write a couple unit tests against sonarbug as part of my QA for it. Will then send it over to Tim.