Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with RoomsHamburgerButton #115

Open
sungchoi opened this issue Nov 21, 2013 · 3 comments
Open

Bug with RoomsHamburgerButton #115

sungchoi opened this issue Nov 21, 2013 · 3 comments

Comments

@sungchoi
Copy link
Contributor

Error: viewTop is null
cannot call $el on null
PageContainer#handleToggleHamburgerLeftCommand

How I get to this error:

  1. Enter a room.
  2. Click hamburgerButton x number of times.
  3. Go back to user home page.
  4. Enter another room
  5. Click hamburgerButton. --> Error
@ghost ghost assigned sungchoi Nov 21, 2013
sungchoi referenced this issue Nov 21, 2013
Bug persists with bandaid. see issue [airbug/airbug#115]
@sungchoi
Copy link
Contributor Author

  1. Enter a room.
  2. Click home button.
  3. Enter room again.
  4. Click hamburgerButton --> Error

yields the same result.

@sungchoi
Copy link
Contributor Author

  1. Enter a room.
  2. Click the hamburger button. --> hamburger panel opens up.
  3. Click another room in the hamburger panel. --> enter new room.
  4. Click the hamburger button --> error.

It appears this error is not caused by clicking the home button or return to the user homepage.
Something with exiting a room and then entering the same or different room.

@sungchoi
Copy link
Contributor Author

Deduced cause: The page container is not being deinitialized; therefore the commandModule subscriptions persist causing an error when called.

This also why the codeEditor button is running into the same problem.

sungchoi referenced this issue Nov 22, 2013
… workaround

until I can figure out how to ensure that the deinitialize method on PageContainer is called.
Extends deinitialize method for PageContainer to unsubscribe from the commandModule.
@sungchoi sungchoi removed their assignment Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant