Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeHints for S3ArtifactStorage_clientconfig incorrect #3275

Open
sbatchelder opened this issue Dec 27, 2024 · 0 comments
Open

TypeHints for S3ArtifactStorage_clientconfig incorrect #3275

sbatchelder opened this issue Dec 27, 2024 · 0 comments
Labels
type / code-health Issue type: suggest a code improvement, i.e. refactoring, deprecation, etc

Comments

@sbatchelder
Copy link
Contributor

Proposed refactoring or deprecation

Correct/remove type-hinting for S3ArtifactStorage_clientconfig(...)

Motivation

Intended use of method doesn't play nice with IDE typing inspection.

image

Pitch

Remove type hinting for S3ArtifactStorage_clientconfig

def S3ArtifactStorage_clientconfig(**boto3_client_kwargs: dict):
 -->
def S3ArtifactStorage_clientconfig(**boto3_client_kwargs):
@sbatchelder sbatchelder added the type / code-health Issue type: suggest a code improvement, i.e. refactoring, deprecation, etc label Dec 27, 2024
sbatchelder added a commit to sbatchelder/aim that referenced this issue Dec 27, 2024
@sbatchelder
aimhubio#3275 bad type hints for **kwargs
630dd86
@sbatchelder sbatchelder mentioned this issue Dec 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type / code-health Issue type: suggest a code improvement, i.e. refactoring, deprecation, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbatchelder