Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

コードプレビュー表示: aigis-codeblock の pre の入れ子 #40

Closed
yomotsu opened this issue Oct 1, 2015 · 2 comments
Closed

コードプレビュー表示: aigis-codeblock の pre の入れ子 #40

yomotsu opened this issue Oct 1, 2015 · 2 comments

Comments

@yomotsu
Copy link

yomotsu commented Oct 1, 2015 

<pre>
  <code class="lang-html">
    <div class="aigis-codeblock aigis-codeblock--html">
      <pre class="editor editor-colors">
        <div class="line">...

になっていますが、

  • code要素はフレージングしか内包できませんつまりdivを入れることはできないため、変えたほうがよさそうです *1
  • preが二重になってしまっていました。ひとつでよさそうです

*1: http://www.w3.org/TR/html5/text-level-semantics.html#the-code-element
@nakajmg
Copy link
Contributor

nakajmg commented Nov 7, 2015

markdownのパーサが外側のpre & codeを作りコードハイライトのライブラリが内側のpreを作るので変更するの難しそう💁

@nakajmg
Copy link
Contributor

nakajmg commented Apr 7, 2016

rel: atom/highlights#26

@nakajmg nakajmg closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yomotsu @nakajmg