Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better file naming in cache #15

Open
chauhankaranraj opened this issue Feb 22, 2021 · 0 comments
Open

Better file naming in cache #15

chauhankaranraj opened this issue Feb 22, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chauhankaranraj
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently the caching function saves the results of a prometheus query as a parquet file whose name is a hash key (e.g. ab0foofbeef0cd). As a first time user of the anomaly detection work, I want to be able to quickly look at the data being used, without having to dive into the notebooks. I also want to be able to easily work with the provided data outside of the notebooks already in the repo. This is a bit tedious right now since I have to manually inspect the demo notebook to know which file corresponds to which prometheus metric.

Describe the solution you'd like
Update the caching function to include the prometheus metric name and possibly some labels in the file name that the result is being saved as.

@chauhankaranraj chauhankaranraj added documentation Improvements or additions to documentation kind/feature Categorizes issue or PR as related to a new feature. good first issue Good for newcomers kind/documentation Categorizes issue or PR as related to documentation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant