Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses using "#" for apartment number aren't matching #95

Closed
jacobdadams opened this issue Sep 24, 2019 · 4 comments
Closed

Addresses using "#" for apartment number aren't matching #95

jacobdadams opened this issue Sep 24, 2019 · 4 comments

Comments

@jacobdadams
Copy link
Member

Addresses that use a number sign ("#") to specify the apartment number don't seem to generate a match.

Random example:

  • "1619 W Thornhill Dr Apt 1308" matches with a score of 100 using the AddressGrid locator.
  • "1619 W Thornhill Dr # 1308" does not match at all.
  • "1619 W Thornhill Dr" gives a match at the same location, same locator, and same score as keeping "Apt 1308" in the address.

It seems like the "#" is throwing the locator off completely. In a set of 1000 addresses, 36 had a Utah address with a "#" sign in the street field and none of them geocoded. Perhaps this is related to or could be fixed with #46?

@steveoh
Copy link
Member

steveoh commented Sep 24, 2019

It is only related to 46 in the sense that we do not use unit numbers when geocoding currently. You could remove them as you will get the same result with or without it as you noted above.

But to address the underlying issue you are experiencing, there are certain characters that have special meaning in urls and therefore need to be encoded to not confuse the browser and api.

Read about it on stack overflow and then encode the values being sent to the api and you should be good to go.

@steveoh steveoh closed this as completed Sep 24, 2019
@jacobdadams
Copy link
Member Author

Ok, yeah, that explains it. I guess atlas.utah.gov was throwing me off because I was seeing the same behavior there, so I assumed it was something to do with the geocoder itself.

@steveoh
Copy link
Member

steveoh commented Sep 24, 2019

@stdavis
Copy link
Member

stdavis commented Sep 24, 2019

I opened an issue in agrc-widgets/dart-board...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants