Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a package #1

Open
ben-williams opened this issue Jun 12, 2020 · 6 comments
Open

make a package #1

ben-williams opened this issue Jun 12, 2020 · 6 comments

Comments

@ben-williams
Copy link

seems this may lend itself to being a forecast package. would be easier to maintain timeline (version control) - thoughts?

@Cole-Monnahan-NOAA
Copy link
Contributor

Agreed -- but only if people will use it. If everyone sticks to the command line then it's probably not worth it. I'd be willing to help convert and maintain moving forward if we go that way.

@jimianelli
Copy link
Collaborator

One approach is to start w/ read-write functionality and reorg of repo structure

@Cole-Monnahan-NOAA
Copy link
Contributor

Wow blast from the past. I'm leaning more toward a package because it allows for easier testing and distribution. Users may never install it but I think the structure would be helpful in general

@jimianelli
Copy link
Collaborator

So...revisiting this topic, some folks have automatic outputs generated from their assessments as inputs to the old proj so maybe the list for settings and pointing to input should be based on reading that (so e.g., a package with a function say "do_proj(mylist)" is a function that takes mylist as an ascii from previous inputs.

@BenWilliams-NOAA
Copy link

i started a "package" branch. stripped out all the non-package components (e.g., cannot have .tpl in src folder etc.) - it is a starting point for a functional package anyway

@BenWilliams-NOAA
Copy link

Oh yeah - I have a projection function we've been using the past few years nested here https://github.com/BenWilliams-NOAA/afscassess/blob/main/R/proj.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants