From 8449e46aeb6bb374e6c92914b25b70c6b3616ef6 Mon Sep 17 00:00:00 2001
From: Denis Davidyuk <denis_davidyuk@hotmail.com>
Date: Wed, 7 Jul 2021 11:25:57 +0300
Subject: [PATCH] refactor: consistent error handling

---
 src/components/FeedItemMenu.vue  | 3 ++-
 src/components/SendComment.vue   | 5 ++---
 src/components/TipInputPopup.vue | 2 +-
 src/components/UserInfo.vue      | 4 ++--
 src/utils/index.js               | 2 +-
 src/views/TipsAndComments.vue    | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/components/FeedItemMenu.vue b/src/components/FeedItemMenu.vue
index 41fccae0e..9d8ec42d8 100644
--- a/src/components/FeedItemMenu.vue
+++ b/src/components/FeedItemMenu.vue
@@ -85,12 +85,13 @@ export default {
           body: this.$t('components.tipRecords.TipRecord.claimBodySuccess'),
         });
         this.resolve();
-      } catch (e) {
+      } catch (error) {
         await this.$store.dispatch('modals/open', {
           name: 'failure',
           title: this.$t('components.tipRecords.TipRecord.claimTitle'),
           body: this.$t('components.tipRecords.TipRecord.claimBodyFailure'),
         });
+        console.error(error);
       }
     },
     async pinOrUnPinTip() {
diff --git a/src/components/SendComment.vue b/src/components/SendComment.vue
index 64710f987..e10e1c74d 100644
--- a/src/components/SendComment.vue
+++ b/src/components/SendComment.vue
@@ -15,7 +15,6 @@
 </template>
 
 <script>
-import { handleUnknownError } from '../utils';
 import MessageInput from './MessageInput.vue';
 
 export default {
@@ -43,8 +42,8 @@ export default {
           { text: this.comment, tipId: this.tipId, parentId: this.parentId },
         );
         this.comment = '';
-      } catch (e) {
-        if (e.message !== 'Operation rejected by user') handleUnknownError(e);
+      } catch (error) {
+        if (error.message !== 'Operation rejected by user') throw error;
       } finally {
         this.loading = false;
       }
diff --git a/src/components/TipInputPopup.vue b/src/components/TipInputPopup.vue
index ceb729f6f..05adc92cf 100644
--- a/src/components/TipInputPopup.vue
+++ b/src/components/TipInputPopup.vue
@@ -130,7 +130,7 @@ export default {
         this.resolve(true);
       } catch (error) {
         this.error = true;
-        throw error;
+        console.error(error);
       } finally {
         this.showLoading = false;
       }
diff --git a/src/components/UserInfo.vue b/src/components/UserInfo.vue
index e414debc6..d82c5d854 100644
--- a/src/components/UserInfo.vue
+++ b/src/components/UserInfo.vue
@@ -264,7 +264,7 @@ export default {
     joinedAtISO() {
       try {
         return new Date(this.profile.createdAt).toISOString();
-      } catch (e) {
+      } catch {
         return '';
       }
     },
@@ -276,7 +276,7 @@ export default {
             month: 'long',
             day: 'numeric',
           });
-      } catch (e) {
+      } catch {
         return '';
       }
     },
diff --git a/src/utils/index.js b/src/utils/index.js
index 9cbd86ff5..898814918 100644
--- a/src/utils/index.js
+++ b/src/utils/index.js
@@ -31,7 +31,7 @@ export const validateTipUrl = (urlAsString) => {
   try {
     const url = toURL(urlAsString);
     return ['http:', 'https:'].includes(url.protocol) && isFQDN(url.hostname);
-  } catch (e) {
+  } catch {
     return false;
   }
 };
diff --git a/src/views/TipsAndComments.vue b/src/views/TipsAndComments.vue
index 1d612af06..2cdf95eb6 100644
--- a/src/views/TipsAndComments.vue
+++ b/src/views/TipsAndComments.vue
@@ -120,7 +120,7 @@ export default {
           ? 'backend/reloadComment' : 'backend/reloadTip', this.id || this.tipId);
       } catch (error) {
         this.error = true;
-        throw error;
+        console.error(error);
       } finally {
         this.showLoading = false;
       }