Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select a name #18

Open
iamparkerm opened this issue Dec 8, 2018 · 2 comments
Open

select a name #18

iamparkerm opened this issue Dec 8, 2018 · 2 comments
Assignees
@iamparkerm

Comments

@iamparkerm
Copy link
Contributor

iamparkerm commented Dec 8, 2018 •
edited
Loading

Who is Bori and why can't you select a name from a list and assign it to the player? Could at least offer a wizard, elf, rogue, etc... Want me to submit a PR?
@iamparkerm
Copy link
Contributor Author

How should I be making contributions? Directly to the master branch?

@aelmosalamy
Copy link
Owner

Yea, just send a pull request with your commit/s and I will merge it into master! Make sure to make your code well-documented, so people can enjoy the treat of reading it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamparkerm iamparkerm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamparkerm @aelmosalamy