From d68ca5364f4f4b8919ade642d0b89c1f4ac5e179 Mon Sep 17 00:00:00 2001 From: wildcat0601 Date: Mon, 29 Jan 2024 10:10:30 +0800 Subject: [PATCH] 1.add mtype in error case output. 2.remove unused codes. --- adapters/adview/adview.go | 35 +---------------------------------- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/adapters/adview/adview.go b/adapters/adview/adview.go index 7e6aca9480f..c26e83ea76e 100644 --- a/adapters/adview/adview.go +++ b/adapters/adview/adview.go @@ -163,21 +163,6 @@ func (a *adapter) buildEndpointURL(params *openrtb_ext.ExtImpAdView) (string, er return macros.ResolveMacros(a.endpoint, endpointParams) } -func getMediaTypeForImp(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType, error) { - mediaType := openrtb_ext.BidTypeBanner - for _, imp := range imps { - if imp.ID == impID { - if imp.Video != nil { - mediaType = openrtb_ext.BidTypeVideo - } else if imp.Native != nil { - mediaType = openrtb_ext.BidTypeNative - } - return mediaType, nil - } - } - return mediaType, nil -} - func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) { switch bid.MType { case openrtb2.MarkupBanner: @@ -189,25 +174,7 @@ func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) { case openrtb2.MarkupNative: return openrtb_ext.BidTypeNative, nil default: - return "", fmt.Errorf("Unable to fetch mediaType in multi-format: %s", bid.ImpID) + return "", fmt.Errorf("Unable to fetch mediaType in impID: %s, mType: %d", bid.ImpID, bid.MType) } } -// getBidType returns the bid type specified in the response bid.ext -func getBidType(bidExt *adviewBidExt) (openrtb_ext.BidType, error) { - // setting "banner" as the default bid type - bidType := openrtb_ext.BidTypeBanner - if bidExt != nil { - switch bidExt.BidType { - case 0: - bidType = openrtb_ext.BidTypeBanner - case 1: - bidType = openrtb_ext.BidTypeVideo - case 2: - bidType = openrtb_ext.BidTypeNative - default: - return "", fmt.Errorf("invalid BidType: %d", bidExt.BidType) - } - } - return bidType, nil -}