Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Contracts endpoint #8

Open
1 of 2 tasks
smarbos opened this issue Jun 18, 2018 · 2 comments
Open
1 of 2 tasks

Contracts endpoint #8

smarbos opened this issue Jun 18, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@smarbos
Copy link
Contributor

smarbos commented Jun 18, 2018

Description:
Create a Contracts Linking an Animal and a Human.

Parameters:

  • humanId (string)
  • animalId (string)

Todo:

  • I think we can use a BEFORE hook to check if both human and animal exists (and do any more check if we need) and then creating the contract. @anabellaspinelli what do you think?
  • Define contract, maybe this should be a variable set by the shelter.
@smarbos smarbos added the enhancement New feature or request label Jun 18, 2018
@smarbos smarbos self-assigned this Jun 18, 2018
@smarbos smarbos added the help wanted Extra attention is needed label Jun 18, 2018
@anabellaspinelli
Copy link
Contributor

Yes about checking existence before persisting. Hoes before broes.

About the "contract" variable:

  • is it just a long string for the whole contract?
  • could they have more than one contract template?
  • either way, in the admin we could provide a way for them to create one or more contracts with "placeholder" fields for names and dates. I think that would be neat.

@smarbos
Copy link
Contributor Author

smarbos commented Jul 3, 2018

  • I think a long string for the contract is ok for starting.
  • I think one contract template is ok to start. It could be defined in the main configuration of the app.
  • I like the placeholder idea, but I think we should keep it simple for the start and add more features in the future.
    I think that using placeholders and multiple contracts templates will increase a lot the complexity of this funcionality.

Another think I would love to take care of is the legal aspect of this contract... Again, let's start with something simple and scale it later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants