Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use top level links? #64

Open
chrisvwlc opened this issue Jan 21, 2020 · 2 comments
Open

Can't use top level links? #64

chrisvwlc opened this issue Jan 21, 2020 · 2 comments

Comments

@chrisvwlc
Copy link

Hi. It seems that top level links without dropdowns won't work.
For example, the following will not work:

<ul class="nav-menu js-nav-menu" id="accessible-megamenu-1578670430615-1">
    <li class="nav-item has-dropdown">
        <a href="#" id="accessible-megamenu-1578670430627-2" role="button" aria-controls="accessible-megamenu-1578670430627-3" aria-expanded="false" tabindex="0" class="">About</a>
        <div class="sub-nav" id="accessible-megamenu-1578670430627-3" role="region" aria-expanded="false" aria-hidden="true" aria-labelledby="accessible-megamenu-1578670430627-2">
            <ul>
                <li><a href="about.php">About Us</a></li>
                <li><a href="services.php">Services</a></li>
            </ul>
        </div>
    </li>
    <li class="nav-item">
        <a href="contacts.php">Contact Lenses</a>
    </li>

Where if I change the second link to:

      <a href="#" id="" role="button" aria-controls="" aria-expanded="false" tabindex="0">Contacts</a>
      <div class="sub-nav" role="region" aria-expanded="false" aria-hidden="true">
        <a href="contacts.php">Contact Lenses</a>
      </div>

It will? How should I handle top level links without sub-navs? For example, social media icons?

@maedi
Copy link
Contributor

maedi commented Jan 24, 2020

The Accessibility Fork will likely fix your problem:
https://github.com/morpht/Accessible-Mega-Menu/tree/accessibility

Which has also been made into a pull request: #66

@maedi
Copy link
Contributor

maedi commented Dec 16, 2020

Fork merged. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants