Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p:layout and pe:layout do not work #72

Closed
Kameecoding opened this issue May 22, 2018 · 6 comments
Closed

p:layout and pe:layout do not work #72

Kameecoding opened this issue May 22, 2018 · 6 comments
Labels

Comments

@Kameecoding
Copy link

Issue Overview

p:layout and pe:layout do not work

Current Behaviour

Adding any of these layouts to the body doesn't work properly

Expected Behaviour

These should probably work

How to reproduce

Add a layout to the body,

<p:layout
 id="allContent"
 fullPage="false"
 style="height: 600px;"
 widgetVar="layout_pane">
  <p:layoutUnit
	  id="two_halves_left"
	  position="center">
  </p:layoutUnit>
  <p:layoutUnit
  	  id="two_halves_right"
	  position="east">
  </p:layoutUnit>
</p:layout>
Additional Information
  • AdminFaces version: RC15
  • PrimeFaces version: 6.1
  • JSF implementation: 2.2
@rmpestano
Copy link
Contributor

Hi @Kameecoding,

can you share any screenshot? I'm interested to see the use case of p:layout within admin-template because this template was supposed to replace p:layout.

Thanks for reporting.

@Kameecoding
Copy link
Author

Kameecoding commented May 23, 2018 via email

@rmpestano
Copy link
Contributor

I see but can you describe your usecase with p:layout? is it just to organize/align/position content? if yes I'd recommend bootstrap grid system or PrimeFaces grid css.

If it is something else can you provide a sample page?

@rmpestano
Copy link
Contributor

rmpestano commented May 23, 2018

I see the visibility:hidden comes from a css file provided by Primefaces, AdminFaces theme doesn't style p:layout, see screenshot:

screenshot from 2018-05-23 14-14-34

Don't know why it comes with visibility hidden but you can fix that with following css rule:

 <ui:define name="body">
  <style type="text/css">
           body .ui-layout-unit {
               visibility: visible;
           }
       </style>
        <p:layout style="min-width:400px;min-height:200px;">
            <p:layoutUnit position="west" resizable="true" size="100" minSize="40" maxSize="200">
                West
            </p:layoutUnit>

            <p:layoutUnit position="center">
                Center
            </p:layoutUnit>
        </p:layout>
</ui:define>

I don't know if it has any side effects.

@Kameecoding
Copy link
Author

Kameecoding commented May 23, 2018 via email

@rmpestano
Copy link
Contributor

This issue was moved to adminfaces/admin-theme#165

@rmpestano rmpestano modified the milestones: 1.0.0, 1.0.0-RC20 Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants