Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primefaces v11 not working. v10 has broken code #17

Open
alin-c opened this issue Feb 22, 2022 · 1 comment
Open

Primefaces v11 not working. v10 has broken code #17

alin-c opened this issue Feb 22, 2022 · 1 comment

Comments

@alin-c
Copy link

alin-c commented Feb 22, 2022

Hi, working on a vanilla clone, I've set Primefaces to v. 11.0.0 and it breaks the app.
Moreover, it seems that even v. 10.0.0 isn't working as expected, out-of-the box because apparently the newer versions (after 8) have different requirements for LazyDataModel() - see load() method signature in CarListMB:
old (working):

public List<Car> load(int first, int pageSize,
          String sortField, SortOrder sortOrder,
          Map<String, FilterMeta> filters){...}

new (expected):

@Override
public List<Car> load(int first, int pageSize, Map<String, SortMeta> map,
          Map<String, FilterMeta> map1) {...}
@rmpestano
Copy link
Contributor

rmpestano commented Feb 22, 2022

Hi @alin-c,

Yes I noticed that, just didn't spend the time to fix it.

Thanks for the feedback!

rmpestano added a commit that referenced this issue Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants