[Estuary] Add more metadata to Video info pane #17179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the following metadata to the Video info pane: - Date *(episode/video)* - DateAdded *(episode/movie/video)* - Duration *(episode/movie/video)* - PlayCount - LastPlayed - DBType This is useful for VOD video plugins to provide additional information related to the video/streams. But it is equally useful for local video media.
|
I removed the Duration from the metadata as it is already available from the Media Flags info. |
ronie
changed the title
ronie
requested changes
Jan 12, 2020
| <param name="control_id" value="161" /> | ||
| <param name="label" value="[COLOR button_focus]$LOCALIZE[570]: [/COLOR]$INFO[ListItem.DateAdded]" /> | ||
| <param name="altlabel" value="$LOCALIZE[570]: $INFO[ListItem.DateAdded]" /> | ||
| <param name="visible" value="!String.IsEmpty(ListItem.DateAdded) + (String.IsEqual(ListItem.DBType,episode) | String.IsEqual(ListItem.DBType,movie) | String.IsEqual(ListItem.DBType,video))" /> |
There was a problem hiding this comment.
please add DBType musicvideo as well.
ronie
added
Component: Skin
Type: Improvement
dagwieers
force-pushed
the
info-pane-metadata
branch
from
1a934b4 to
c7a2fd6
Compare
|
looks good to me, thx! |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Jan 21, 2020
[Estuary] Add more metadata to Video info pane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following metadata to the Video info pane (when available):
Duration (episode/movie/video)Motivation and Context
This is useful for VOD video plugins to provide additional information
related to the video/streams. But it is equally useful for local video
media.
This fixes add-ons/plugin.video.vrt.nu#674
How Has This Been Tested?
This has been tested on Kodi Leia mostly, however this part of the skin is not different to Kodi Matrix.
Screenshots (if appropriate):
Screenshot for local movie
Screenshot for local TV show
Screenshot for local TV show episode
Screenshot for VOD movie
Screenshot for VOD TV show episode
Types of change
Checklist: