Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get/set video position in Kodi database #568

Open
dagwieers opened this issue Nov 4, 2019 · 3 comments
Open

Unable to get/set video position in Kodi database #568

dagwieers opened this issue Nov 4, 2019 · 3 comments
Labels
enhancement New feature or request kodi Related to the Kodi media player merged A fix for this issue has been merged by upstream

Comments

@dagwieers
Copy link
Collaborator

dagwieers commented Nov 4, 2019

Describe the feature

Since the VOD provider (VRT NU) stores the position of a stream and watch-status in its infrastructure (among other things) and we would like to integrate with this so users can continue watching from Kodi, or from their smartphone, or web-browser, we have the need to update a stream's position in the Kodi database.

We currently set the position and watch-status while generating the listing in Kodi, however this has the nasty downside that we have to controle when the listing is regenerated (i.e. after a stream has been played, or played partly). This does not give a good user experience.

The other downside currently is that the context-menu items Reset resume position and Mark as watched/unwatched do not work as we cannot intercept this event to update the position online.

The obvious solution is to use Files.GetFileDetails and Files.SetFileDetails JSON-RPC calls to synchronize resumeposition and playcount information, however these calls are not supported for 'plugin://'-type resources so they are not useful for add-on developers. xbmc/xbmc#15897

The proposed fix is simple but got rejected: xbmc/xbmc#16087

As a result the current implementation of resumepoints works but with various quirks and issues.

@dagwieers dagwieers added enhancement New feature or request kodi Related to the Kodi media player help wanted Extra attention is needed labels Nov 4, 2019
@michaelarnauts
Copy link
Contributor

Another approach is to directly access the database, but this will get rejected for the official repo. If I remember correctly, PlexKodiConnect is doing this.

@dagwieers dagwieers added the reported This issue has been reported to upstream project label Jan 5, 2020
@dagwieers
Copy link
Collaborator Author

I opened a feature request upstream at https://forum.kodi.tv/showthread.php?tid=350726

@dagwieers dagwieers added fixed An upstream fix is available but not yet released and removed help wanted Extra attention is needed reported This issue has been reported to upstream project labels Jan 16, 2020
@dagwieers dagwieers added merged A fix for this issue has been merged by upstream and removed fixed An upstream fix is available but not yet released labels Jan 28, 2020
@dagwieers
Copy link
Collaborator Author

@CastagnaIT laid out a callback mechanism that can do this. We will need to document the implementation in the add-ons/best-practices wiki. So there is hope !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kodi Related to the Kodi media player merged A fix for this issue has been merged by upstream
Projects
None yet
Development

No branches or pull requests

2 participants