Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission for inclusion in Cardinal #21

Open
falkTX opened this issue Feb 26, 2022 · 6 comments
Open

Permission for inclusion in Cardinal #21

falkTX opened this issue Feb 26, 2022 · 6 comments

Comments

@falkTX
Copy link

falkTX commented Feb 26, 2022

Hi there.
I would like to include your modules as part of Cardinal, which the code license allows but I am unsure regarding the graphics.

The README only states:

The panel graphics in the res/ folder are copyright © Alex Brandt

But this is not a license, just a copyright notice. Would you mind placing a license for your artwork files? The CC-BY-SA is the one that most closely matches GPL in spirit, there are also optional non-commercial and non-derivate clauses possible (though that restricts what can be done with the project). Otherwise CC-0/Public-Domain allows everything,

Thanks, have a great day!

@adbrant
Copy link
Owner

adbrant commented Feb 27, 2022

Hello!
I would be happy for these modules to be included in cardinal.
The artwork in the repo are modified versions of the originals from the AudibleInstruments repo, so I am not sure if I can change the licensing. I think you should be ok to use these in the same way as the originals.
I cant find the notice "The panel graphics in the res/ folder are copyright © Alex Brandt" in the repo, but I wouldn't have a problem removing it.
Thanks,
Alex

@falkTX
Copy link
Author

falkTX commented Feb 27, 2022

The artwork in the repo are modified versions of the originals from the AudibleInstruments repo, so I am not sure if I can change the licensing. I think you should be ok to use these in the same way as the originals.

Fair enough. Luckily Emilie already gave thumbs up for its use in Cardinal.
You give permission too, so all should be fine.

I cant find the notice "The panel graphics in the res/ folder are copyright © Alex Brandt" in the repo, but I wouldn't have a problem removing it.

It was added in 224610d for the v2 branch.

@falkTX
Copy link
Author

falkTX commented Feb 28, 2022

FYI I have tweaked the design a bit, because to be honest I find the regular one a bit ugly, and too bright.
So I inverted the colors, made the panel outline work (as any other modules have) and also cleaned up and made the background png blurry.
This is the result:

image

I would like to use this version for Cardinal, is that ok with you?
If you like the design I can submit a PR, otherwise it will be specific to Cardinal. Due to me changing the files we cannot have both yours and my modified version at the same time though..

@falkTX
Copy link
Author

falkTX commented Feb 28, 2022

Did similar things for Neil now too.

Screenshot_20220228_154502

@falkTX
Copy link
Author

falkTX commented Sep 15, 2022

Hi.

I adjusted the panels to keep in mind the original artwork. Should have realized earlier that there was a point for this specific artwork and modules names..
So "Joni" one now keeps the original painting in there, in a similar fashion to what "Neil" has.

image

Should I submit these changes as pull request? Would you be interested on them?

@adbrant
Copy link
Owner

adbrant commented Oct 6, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants