From cbaf50bd84401eec46556b97cd266974ee4848c9 Mon Sep 17 00:00:00 2001
From: Oliver Foster <oliver.foster@kineo.com>
Date: Mon, 16 Sep 2024 19:44:45 +0100
Subject: [PATCH] Fix: Allow tooltips to follow animations

---
 js/views/TooltipItemView.js | 23 ++++++++++++++++++++---
 js/views/adaptView.js       |  2 ++
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/js/views/TooltipItemView.js b/js/views/TooltipItemView.js
index ae7fc8f5..7acadbfc 100644
--- a/js/views/TooltipItemView.js
+++ b/js/views/TooltipItemView.js
@@ -48,12 +48,17 @@ export default class TooltipItemView extends Backbone.View {
     this.parent = parent;
     this.$target.attr('aria-describedby', `tooltip-${this.model.get('_id')}`);
     this.listenTo(this.model, 'change', this.changed);
-    this.listenTo(Adapt, 'device:resize', this.onDeviceResize);
+    this.listenTo(Adapt, {
+      'contentObjectView:ready': this.changed,
+      'view:animationStart': this.changed,
+      'device:resize': this.onDeviceResize
+    });
     this.listenTo(Adapt.parentView, 'preRemove', this.remove);
     if (!this.isStatic) {
       // Should not hide static tooltips on blur
       $(document).on('mouseleave blur', '[data-tooltip-id]', this.onMouseOut);
     }
+    this.unchangedRenders = 0;
     this.changed();
   }
 
@@ -152,7 +157,7 @@ export default class TooltipItemView extends Backbone.View {
   }
 
   doSubsequentPasses() {
-    if (!this.model) return;
+    if (!this.model) return false;
     this.model.set('hasLoaded', true, { silent: true });
     const multipassCache = {};
     // First pass - render at the requested position
@@ -179,6 +184,10 @@ export default class TooltipItemView extends Backbone.View {
     this.model.set('isShown', true, { silent: true });
     this.render();
     this.model.set('wasShown', true, { silent: true });
+    const endHash = JSON.stringify(this.model.get('tooltipStyles'));
+    const hasChanged = (this.startHash !== endHash);
+    this.startHash = endHash;
+    return hasChanged;
   }
 
   render() {
@@ -193,7 +202,15 @@ export default class TooltipItemView extends Backbone.View {
     if (!this.model) return;
     requestAnimationFrame(() => {
       this.doFirstPass();
-      this.doSubsequentPasses();
+      const hasChanged = this.doSubsequentPasses();
+      // rerender if unchanged for 34 frames (1second @ 30fps)
+      if (!hasChanged) this.unchangedRenders++;
+      if (hasChanged) this.unchangedRenders = 0;
+      if (this.unchangedRenders >= 34) {
+        this.unchangedRenders = 0;
+        return;
+      }
+      this.changed();
     });
   }
 
diff --git a/js/views/adaptView.js b/js/views/adaptView.js
index 9a5b0037..97bcff7b 100644
--- a/js/views/adaptView.js
+++ b/js/views/adaptView.js
@@ -136,6 +136,8 @@ class AdaptView extends Backbone.View {
       const minVerticalInview = onscreen._percentInviewVertical || 33;
       if (m.percentInviewVertical < minVerticalInview) return;
       this.$el.addClass(`${onscreen._classes}-after`).off('onscreen.adaptView');
+      const type = this.model.get('_type');
+      Adapt.trigger(`${type}View:animationStart view:animationStart`, this);
     });
   }