Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated code from this repository #51

Open
brody4hire opened this issue Jan 31, 2018 · 1 comment
Open

Remove generated code from this repository #51

brody4hire opened this issue Jan 31, 2018 · 1 comment

Comments

@brody4hire
Copy link

Use npm prepare script to generate needed objects before publishing. For example:

I would be happy to help with this one if you like. Maybe within the next 1-2 weeks.

@adamhaile
Copy link
Owner

FWIW, I'm currently checking in the built assets for two reasons:

  1. (small reason) it makes it marginally easier to have some scratch and demo scripts that run against current master, and
  2. (bigger) b/c I'm transpiling from typescript, I manually review the generated code to make sure the transpiler didn't introduce any non-performant patterns. Having the built assets checked in makes that very easy -- I just check the changed sections in the diff.

If I start getting substantial community contributions to the code, I'll probably flip the other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants