Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feather Sense to HX8357 example sketches #37

Open
DJDevon3 opened this issue Jul 9, 2020 · 1 comment
Open

Add Feather Sense to HX8357 example sketches #37

DJDevon3 opened this issue Jul 9, 2020 · 1 comment

Comments

@DJDevon3
Copy link

DJDevon3 commented Jul 9, 2020

  • Arduino board: Adafruit NRF52840 Feather Sense
  • Arduino IDE version: 1.8.13

All of the HX8357 example sketches do not have the feather sense board explicitly listed and will fail to compile. Compile error states this line is faulty: Adafruit_HX8357 tft = Adafruit_HX8357(TFT_CS, TFT_DC);
'TFT_CS' was not declared in this scope

To fix simply add the board (ARDUINO_NRF52840_FEATHER_SENSE) to the anything else list and the sketches work. Very simple fix. Every HX8357 example sketch needs to be updated.

// Anything else! #if defined (__AVR_ATmega32U4__) || defined(ARDUINO_SAMD_FEATHER_M0) || defined (__AVR_ATmega328P__) || \ defined(ARDUINO_SAMD_ZERO) || defined(__SAMD51__) || defined(__SAM3X8E__) || defined(ARDUINO_NRF52840_FEATHER) || defined(ARDUINO_NRF52840_FEATHER_SENSE) #define STMPE_CS 6 #define TFT_CS 9 #define TFT_DC 10 #define SD_CS 5 #endif

@ladyada
Copy link
Member

ladyada commented Jul 9, 2020

hi can you submit a PR? that would be great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants