From 75d7987dd544f5921c48b28844ecd400b742bac1 Mon Sep 17 00:00:00 2001 From: Joel Jeremy Marquez Date: Mon, 20 Jan 2025 10:37:57 -0800 Subject: [PATCH 1/2] Update validateBudgetName and uniqueBudgetName per coderabbit review --- packages/loot-core/src/client/actions/budgets.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/loot-core/src/client/actions/budgets.ts b/packages/loot-core/src/client/actions/budgets.ts index ab549a23510..1c770f26d1b 100644 --- a/packages/loot-core/src/client/actions/budgets.ts +++ b/packages/loot-core/src/client/actions/budgets.ts @@ -148,11 +148,14 @@ export function createBudget({ testMode = false, demoMode = false } = {}) { }; } -export function validateBudgetName(name: string) { +export async function validateBudgetName(name: string): Promise<{ + valid: boolean; + message?: string; +}> { return send('validate-budget-name', { name }); } -export function uniqueBudgetName(name: string) { +export async function uniqueBudgetName(name: string): Promise { return send('unique-budget-name', { name }); } From 7e19f1ff856046776c646ea91143ab87cf184b05 Mon Sep 17 00:00:00 2001 From: Joel Jeremy Marquez Date: Mon, 20 Jan 2025 10:39:20 -0800 Subject: [PATCH 2/2] Release notes --- upcoming-release-notes/4208.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 upcoming-release-notes/4208.md diff --git a/upcoming-release-notes/4208.md b/upcoming-release-notes/4208.md new file mode 100644 index 00000000000..16b7f1c222b --- /dev/null +++ b/upcoming-release-notes/4208.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [joel-jeremy] +--- + +[Typescript] Update validateBudgetName and uniqueBudgetName return types \ No newline at end of file