From 75c03bcfab92e101e373b37d5924cba84dfaaaf9 Mon Sep 17 00:00:00 2001 From: sergiofmreis <54979205+sergiofmreis@users.noreply.github.com> Date: Fri, 10 Jan 2025 14:44:48 +0000 Subject: [PATCH 1/3] add support for ABANCA_CORP_CAGLPTPL payee name --- src/app-gocardless/banks/abanca_caglesmm.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app-gocardless/banks/abanca_caglesmm.js b/src/app-gocardless/banks/abanca_caglesmm.js index 7a81aa2e9..55129b2fa 100644 --- a/src/app-gocardless/banks/abanca_caglesmm.js +++ b/src/app-gocardless/banks/abanca_caglesmm.js @@ -6,7 +6,7 @@ import { formatPayeeName } from '../../util/payee-name.js'; export default { ...Fallback, - institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL'], + institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'], // Abanca transactions doesn't get the creditorName/debtorName properly normalizeTransaction(transaction, _booked) { From afb98fae2172565cb0cece8bf5907194ff22b432 Mon Sep 17 00:00:00 2001 From: sergiofmreis <54979205+sergiofmreis@users.noreply.github.com> Date: Fri, 10 Jan 2025 14:45:55 +0000 Subject: [PATCH 2/3] Create Release Notes file --- upcoming-release-notes/550.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 upcoming-release-notes/550.md diff --git a/upcoming-release-notes/550.md b/upcoming-release-notes/550.md new file mode 100644 index 000000000..fe13d172d --- /dev/null +++ b/upcoming-release-notes/550.md @@ -0,0 +1,6 @@ +--- +category: Features +authors: [sergiofmreis] +--- + +Add support for `ABANCA_CORP_CAGLPTPL` payee name From 1e0dfb22855af093be4bf6ba218d0e7f9cf0c718 Mon Sep 17 00:00:00 2001 From: sergiofmreis <54979205+sergiofmreis@users.noreply.github.com> Date: Sat, 18 Jan 2025 13:53:17 +0000 Subject: [PATCH 3/3] Lint institutionIds array Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- src/app-gocardless/banks/abanca_caglesmm.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/app-gocardless/banks/abanca_caglesmm.js b/src/app-gocardless/banks/abanca_caglesmm.js index 55129b2fa..905175098 100644 --- a/src/app-gocardless/banks/abanca_caglesmm.js +++ b/src/app-gocardless/banks/abanca_caglesmm.js @@ -6,7 +6,11 @@ import { formatPayeeName } from '../../util/payee-name.js'; export default { ...Fallback, - institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'], + institutionIds: [ + 'ABANCA_CAGLESMM', + 'ABANCA_CAGLPTPL', + 'ABANCA_CORP_CAGLPTPL', + ], // Abanca transactions doesn't get the creditorName/debtorName properly normalizeTransaction(transaction, _booked) {