Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic testing for i18n-check #2

Open
2 tasks done
andrewtavis opened this issue Dec 21, 2024 · 4 comments
Open
2 tasks done

Basic testing for i18n-check #2

andrewtavis opened this issue Dec 21, 2024 · 4 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Once we have the scripts migrated over from activist, the next step would be to add pytest based testing to the directory. We’d want to have some fake data in the testing files with valid and invalid i18n uses and make sure that future changes maintains the current functionality. This will also allow us to guide development in the future when we try to expand the functionality of the package.

Contribution

Happy to work on this and review when a PR is up! 😊

@andrewtavis
Copy link
Member Author

As a part of this, we'd want to use the new YAML file for all check scripts:

  • Load in .i18n-check.yaml
  • Replace all instances of file_types_to_check, directories_to_skip and files_to_skip with the data from the yaml file

Then we can move on to writing Pytest tests for this :)

@andrewtavis
Copy link
Member Author

@OmarAI2003, don't forget to write in here so I can assign :)

@OmarAI2003
Copy link
Contributor

Here and ready to be assigned! 👍

@andrewtavis
Copy link
Member Author

Assigned! Let me know if you need any support here, @OmarAI2003 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants