-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Signal to Modal Share Page Component #694
Comments
Note: Modal Share Page Component #581 is in progress |
@andrewtavis @GrandSuccess87 I created the pull request to add the icon. But am not sure what URL we are linking to from it. |
Hey @Mister-Tofu-tech 👋 Thanks for sending along the PR. I'll make some comments as there are things that would need to change, and then maybe we can figure out what URL it should point to and you can implement that as well :) |
Hi, I would be happy to work on this. Thanks! |
@UnknownSean8 will be helping a bit on the share part of this once I bring in @Mister-Tofu-tech's PR :) Thanks, @UnknownSean8! |
Ping @UnknownSean8 👋 With ea8f4fe and #855 being merged we're ready to work on the share functionality :) Thanks for the work here, @Mister-Tofu-tech! |
Closed via #955 🚀 Thanks for the all the efforts here, all, and especially for the great execution, @UnknownSean8! We're not able to directly open Signal with a message, but copying the URL and opening the app should work well 😊 |
Terms
Description
This issue will focus on adding support to share activist pages (event/organization/group) on Signal via the modal share page component.
This component lives in frontend/components/modal.
Icons would ideally come from one icon source on Icones such as CoreUI Brands.
You may also find the icons you need on Bootstrap.
Contribution
Happy to pair up with someone on this or tackle it myself :))
The text was updated successfully, but these errors were encountered: