Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18nMap on frontend build #1097

Open
2 tasks done
andrewtavis opened this issue Jan 19, 2025 · 3 comments
Open
2 tasks done

Update i18nMap on frontend build #1097

andrewtavis opened this issue Jan 19, 2025 · 3 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

activist adopted the use of the i18nMap object in #1094. One thing that's needed is that the functionality to update the map should be ran each time the frontend is built to make sure that new developers in the community don't run into issues when they update the i18n keys and forget to update the object. Ideally this would be the frontend/i18n/check/i18n_generate_map_object.py script being ran on yarn build, but we can also look into other solutions here :)

Contribution

Happy to help devise a solution to this and work with people to implement this functionality! 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Jan 19, 2025
@Suz99
Copy link

Suz99 commented Jan 21, 2025

Hi @andrewtavis! Can this issue be assigned to me?

@andrewtavis
Copy link
Member Author

Yes, @Suz99! Thanks for your willingness to take this on! 😊

@Suz99
Copy link

Suz99 commented Jan 22, 2025

Hi @andrewtavis! I had a doubt, if I wanted i18n_generate_map_object.py to run on yarn build, I would have to update the json file with "frontend/i18n/check/i18n_generate_map_object.py && yarn webpack" to execute the py script. Can you direct me to where I should add this to the project?

Suz99 added a commit to Suz99/activist that referenced this issue Jan 24, 2025
- encapsulated the functionality is wrapped in a main() function
-This modification ensures that each time the build process is run, the Python script updates the i18n keys automatically, making the build process robust and maintaining consistency across the application.

Signed-off-by: Suzana <[email protected]>
@Suz99 Suz99 mentioned this issue Jan 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants